-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[megatron] feat: support qwen2 megatron backend #261
Merged
vermouth1992
merged 8 commits into
volcengine:main
from
kinman0224:kinman/feat_qwen_megatron
Feb 19, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
75d369d
[feat] support qwen2 megatron backend
kinman0224 b33325c
add example
kinman0224 d545ba7
Merge branch 'main' into kinman/feat_qwen_megatron
kinman0224 8e36b3e
misc
kinman0224 2e2ab19
update ci
kinman0224 e7e9e56
update ci
kinman0224 45daa8f
fix share_embeddings_and_output_weights problem
kinman0224 f7ec091
Merge branch 'volcengine:main' into kinman/feat_qwen_megatron
kinman0224 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
set -x | ||
|
||
export VLLM_ATTENTION_BACKEND=XFORMERS | ||
|
||
gsm8k_train_path=$HOME/data/gsm8k/train.parquet | ||
gsm8k_test_path=$HOME/data/gsm8k/test.parquet | ||
math_train_path=$HOME/data/math/train.parquet | ||
math_test_path=$HOME/data/math/test.parquet | ||
|
||
train_files="['$gsm8k_train_path', '$math_train_path']" | ||
test_files="['$gsm8k_test_path', '$math_test_path']" | ||
|
||
python3 -m verl.trainer.main_ppo --config-path=./config --config-name='ppo_megatron_trainer'\ | ||
data.train_files="$train_files" \ | ||
data.val_files="$test_files" \ | ||
data.train_batch_size=1024 \ | ||
data.val_batch_size=6312 \ | ||
data.max_prompt_length=1024 \ | ||
data.max_response_length=512 \ | ||
actor_rollout_ref.model.path=Qwen/Qwen2-7B-Instruct \ | ||
actor_rollout_ref.actor.optim.lr=1e-6 \ | ||
actor_rollout_ref.actor.ppo_mini_batch_size=256 \ | ||
actor_rollout_ref.actor.ppo_micro_batch_size_per_gpu=4 \ | ||
actor_rollout_ref.rollout.log_prob_micro_batch_size_per_gpu=4 \ | ||
actor_rollout_ref.rollout.tensor_model_parallel_size=4 \ | ||
actor_rollout_ref.rollout.name=vllm \ | ||
actor_rollout_ref.rollout.gpu_memory_utilization=0.4 \ | ||
actor_rollout_ref.ref.log_prob_micro_batch_size_per_gpu=4 \ | ||
critic.optim.lr=1e-5 \ | ||
critic.model.path=Qwen/Qwen2-7B-Instruct \ | ||
critic.model.enable_gradient_checkpointing=False \ | ||
critic.ppo_micro_batch_size_per_gpu=4 \ | ||
algorithm.kl_ctrl.kl_coef=0.001 \ | ||
trainer.critic_warmup=0 \ | ||
trainer.logger=['console','wandb'] \ | ||
trainer.project_name='verl_megatron_math_gsm8k_examples' \ | ||
trainer.experiment_name='qwen2_7b_function_rm' \ | ||
trainer.n_gpus_per_node=8 \ | ||
trainer.nnodes=1 \ | ||
trainer.save_freq=-1 \ | ||
trainer.test_freq=5 \ | ||
trainer.total_epochs=100 $@ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
set -x | ||
|
||
# the config file used: verl/trainer/main_ppo/config/ppo_megatron_trainer.yaml | ||
|
||
huggingface-cli download Qwen/Qwen2.5-0.5B | ||
|
||
python3 -m verl.trainer.main_ppo --config-path=config \ | ||
--config-name='ppo_megatron_trainer.yaml'\ | ||
data.train_files=$HOME/data/gsm8k/train.parquet \ | ||
data.val_files=$HOME/data/gsm8k/test.parquet \ | ||
data.train_batch_size=1024 \ | ||
data.val_batch_size=1312 \ | ||
data.max_prompt_length=512 \ | ||
data.max_response_length=512 \ | ||
actor_rollout_ref.model.path=Qwen/Qwen2.5-0.5B \ | ||
actor_rollout_ref.actor.optim.lr=2e-6 \ | ||
actor_rollout_ref.actor.ppo_mini_batch_size=256 \ | ||
actor_rollout_ref.actor.ppo_micro_batch_size_per_gpu=4 \ | ||
actor_rollout_ref.actor.megatron.tensor_model_parallel_size=2 \ | ||
actor_rollout_ref.rollout.log_prob_micro_batch_size_per_gpu=8 \ | ||
actor_rollout_ref.rollout.tensor_model_parallel_size=2 \ | ||
actor_rollout_ref.rollout.name=vllm \ | ||
actor_rollout_ref.rollout.gpu_memory_utilization=0.5 \ | ||
actor_rollout_ref.ref.log_prob_micro_batch_size_per_gpu=16 \ | ||
actor_rollout_ref.ref.megatron.tensor_model_parallel_size=2 \ | ||
critic.optim.lr=2e-5 \ | ||
critic.model.path=Qwen/Qwen2.5-0.5B \ | ||
critic.model.enable_gradient_checkpointing=False \ | ||
critic.ppo_micro_batch_size_per_gpu=4 \ | ||
critic.megatron.tensor_model_parallel_size=2 \ | ||
algorithm.kl_ctrl.kl_coef=0.001 \ | ||
trainer.critic_warmup=0 \ | ||
trainer.logger=['console'] \ | ||
trainer.project_name='verl_megatron_gsm8k_examples' \ | ||
trainer.experiment_name='qwen2_5_0b5_function_rm' \ | ||
trainer.n_gpus_per_node=8 \ | ||
trainer.nnodes=1 \ | ||
trainer.save_freq=-1 \ | ||
trainer.test_freq=1 \ | ||
trainer.total_epochs=15 \ | ||
trainer.total_training_steps=3 $@ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Copyright 2024 Bytedance Ltd. and/or its affiliates | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# Copyright 2024 Bytedance Ltd. and/or its affiliates | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from .modeling_qwen2_megatron import ( | ||
# original model with megatron | ||
ParallelQwen2Model, | ||
ParallelQwen2ForCausalLM, | ||
# rmpad with megatron | ||
ParallelQwen2ForCausalLMRmPad, | ||
ParallelQwen2ForValueRmPad, | ||
# rmpad with megatron and pipeline parallelism | ||
ParallelQwen2ForCausalLMRmPadPP, | ||
ParallelQwen2ForValueRmPadPP) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Copyright 2024 Bytedance Ltd. and/or its affiliates | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could u later also add a section to https://github.com/volcengine/verl/blob/main/docs/experiment/ppo.rst , add a new table for MATH, and include the logs, command, and test score in next PR