feat: Expose remove_previous_ckpt option to training entry point an…
#274
+27
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d user configuration - Add `remove_previous_ckpt` configuration option in `ppo_trainer.yaml` - Update `RayPPOTrainer` to support optional checkpoint deletion during loading - Modify `ActorRolloutRefWorker` and `CriticWorker` to pass checkpoint removal flag
- Rename `remove_previous_ckpt` in config file to more specific `remove_previous_ckpt_in_save` - Add new `del_local_ckpt_after_load` configuration option in config file - Update checkpoint loading and saving methods to use new configuration names
- Change default value of `remove_previous_ckpt_in_save` to `False` in `ppo_trainer.yaml` - Change default value of `del_local_ckpt_after_load` to `False` in `ppo_trainer.yaml` - Update `FSDPCheckpointManager` and `ActorRolloutRefWorker` to use new default values
PeterSH6
reviewed
Feb 14, 2025
…point saving methods - Modify `ActorRolloutRefWorker` and `CriticWorker` to accept optional `remove_previous_ckpt` parameter
PeterSH6
approved these changes
Feb 15, 2025
as12138
pushed a commit
to as12138/verl
that referenced
this pull request
Feb 20, 2025
volcengine#274) Related issue: volcengine#273 - Add `remove_previous_ckpt_in_save` and `del_local_ckpt_after_load` configuration option in `ppo_trainer.yaml` - Update `RayPPOTrainer` to support optional checkpoint deletion during loading - Modify `ActorRolloutRefWorker` and `CriticWorker` to pass checkpoint removal flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #273
remove_previous_ckpt_in_saveanddel_local_ckpt_after_loadconfiguration option inppo_trainer.yamlRayPPOTrainerto support optional checkpoint deletion during loadingActorRolloutRefWorkerandCriticWorkerto pass checkpoint removal flag