Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Deprecate val_batch_size #353

Merged
merged 3 commits into from
Feb 24, 2025
Merged

[Fix] Deprecate val_batch_size #353

merged 3 commits into from
Feb 24, 2025

Conversation

tongyx361
Copy link
Contributor

Validation datasets are sent to inference engines as a whole batch, which will schedule the memory themselves.

  • Remove val_batch_size from examples
  • Set default values of val_batch_size in configs as null and add DEPRECATED comments
  • Add deprecation warnings about val_batch_size in _validate_config

PeterSH6
PeterSH6 reviewed Feb 23, 2025
View reviewed changes
@tongyx361 tongyx361 requested a review from PeterSH6 February 23, 2025 13:39
@vermouth1992 vermouth1992 merged commit 4011f40 into volcengine:main Feb 24, 2025
12 checks passed
@tongyx361 tongyx361 deleted the tyx/fix/val-batch-size branch February 24, 2025 02:24
@vermouth1992 vermouth1992 mentioned this pull request Feb 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vermouth1992 vermouth1992 vermouth1992 approved these changes

@PeterSH6 PeterSH6 Awaiting requested review from PeterSH6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tongyx361 @vermouth1992 @PeterSH6