allow shairport to control volume #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem when AirPlay playback volume is limited by the system volume as reported on the community forums here and here.
Currently there are two separate volume controls: one managed by shairport-sync, responding to the source volume changes; second managed by Volumio, responding to the changes in UI and other events.
The PR changes the behavior by setting
ignore_volume_controlin the shairport-sync.conf file, effectively disabling the volume control done by shairport-sync itself, and passing the volume change events from the source to Volumio, letting it do the volume control as it should.PS: This is my first contribution to Volumio, discussion is welcome :)