Set Winston log level to "debug"

[gvolt]

Fixes #74

[volumio]

Log is not set on verbose to not pollute logs.
But it could be a good thing to have, just not always.

I propose:

• Set a global env variable which defines the current log status
• So in plugins, when in dev mode, the env variable is changed
  What do ou think?

[gvolt]

I am currently working on adding a selector list to the config page of plugins which would let the user set the logging level from "off" to "debug" - so some sort of a global variable. Default would be "error" or could be "off". But it might be overkill and I will consider switching on/off logging depending on dev mode. Is there a method to query if dev mode is on or would one just check of "/data/testplugins" exists?

Would it make sense to use winston's filter function to make controllable what type of messages are shown?

[volumio]

Yeah, I think that this will be an overkill.
DEV mode I think it's the wisest idea ;)

You can just check /data/testplugins existence

Or even better, just provide it as a manual flag that plugin developer can use during work. Or a command line command from volumio plugin which sets the logging to desired level by adding the info to a specific file

[gvolt]

"... Or a command line command from volumio plugin which sets the logging to desired level by adding the info to a specific file": Wouldn't that require "pluginhelper.js" to be extended or did I misunderstand "volumio plugin"?

[volumio]

Yes, exactly. Which IMHO would be a good tool for plugins developer

[gvolt]

Just another thought on using "/data/testplugins": I think quite a lot of users have set Test Plugins mode on and leave it at this. If plugin's just rely on the testplugins file extensive logging will still happen on many systems where it is not required/wanted. So IMHO a dedictated flag file e.g. in "/data/configuration/plugin_type/plugin_name" or maybe in "/data/plugins/plugin_type/plugin_name" would be the better choice - or a new volumio plugin command.

Since I never tried it: Would "volumio plugin" also work from the the directory of a plugin already installed, i.e. from "/data/plugins/plugin_type/plugin_name"?

[volumio]

I agree, IMHO we shall just add an entry to plugin

volumio plugin debugmode

which toggles the creation of a file like /data/plugins/debugmode

If this file is there, we set to debug, otherwise we don't.
This will work on global volumio, not a single plugin

[gvolt]

IMHO that would be a good compromise. Maybe an according button on the "dev" page makes sense, too.

BTW: Would you prefer plugin's logging to be completely silenced by default (even error messages)?

[volumio]

Yeah I agree.

No, I would leave plugin logging as they are now ;)

[gvolt]

Ok, so bottom line the "debugmode" file should only unlock "self.logger.debug"?

[volumio]

Yep