Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __init__ files to test packages #418

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Conversation

jonahkagan
Copy link
Contributor

@jonahkagan jonahkagan commented Apr 7, 2020

Description

This ensures that mypy will typecheck them. mypy doesn't recursively
check directories without an __init__ file. See: python/mypy#6385.

Testing

N/A

Progress

Ready for review.

@jonahkagan jonahkagan requested a review from benadida April 7, 2020 18:36
@benadida benadida temporarily deployed to vx-arlo-staging-pr-418 April 7, 2020 18:36 Inactive
@jonahkagan
Copy link
Contributor Author

cc @umbernhard, for future reference

This ensures that mypy will typecheck them. mypy doesn't recursively
check directories without an __init__ file. See: python/mypy#6385
@jonahkagan jonahkagan force-pushed the typecheck-all-tests branch from ce5e896 to d93af14 Compare April 7, 2020 22:26
@benadida benadida temporarily deployed to vx-arlo-staging-pr-418 April 7, 2020 22:26 Inactive
@jonahkagan jonahkagan force-pushed the typecheck-all-tests branch from d93af14 to f804566 Compare April 7, 2020 22:31
@jonahkagan jonahkagan merged commit f1bec65 into master Apr 8, 2020
@jonahkagan jonahkagan deleted the typecheck-all-tests branch April 8, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants