Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict accepted logins by GitHub organization #150

Closed
RyanGannon opened this issue Sep 19, 2019 · 3 comments
Closed

restrict accepted logins by GitHub organization #150

RyanGannon opened this issue Sep 19, 2019 · 3 comments

Comments

@RyanGannon
Copy link

Is it possible to restrict accepted logins by GitHub organization? That is, instead of restricting by email address domain or just allowing anyone on GitHub access to my site, can I set Vouch to only allow members of a specified GitHub organization to access my site?

I feel I'm missing something simple.

@bnfinet bnfinet changed the title Is it possible to restrict accepted logins by GitHub organization? restrict accepted logins by GitHub organization Sep 20, 2019
@bnfinet
Copy link
Member

bnfinet commented Sep 20, 2019

To the best of my understanding, no it is not possible.

If GitHub provided any Oauth Claim in their token which indicated organizational status it should be possible to use Openresty to fiiter users, but I don't believe they do
https://github.com/vouch/vouch-proxy#advanced-authorization-using-openresty

GitHub team membership is a separate api call
https://developer.github.com/v3/orgs/members/#check-membership

It's possible this api call could be added to the auth/userinfo logic but it would require some thought. We don't have anything like that in the code base at this point.

@RyanGannon
Copy link
Author

Thank you. This answers my question.

@bnfinet
Copy link
Member

bnfinet commented Feb 7, 2020

@RyanGannon FYI - @eikehartmann has submitted a PR which supports GitHub orgs and teams

If you were in a position to help test it would be much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants