Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uppercase configuration environment variables #117

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Feb 20, 2023

This changes the preferred usage of BEAKER_x to BEAKER_X, so BEAKER_DESTROY instead of BEAKER_destroy. The old names are still supported.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase in environment variables is awkward and inconsistent with the rest of the tooling I am used to on UNIX-like OS. +1 for this!

This changes the preferred usage of BEAKER_x to BEAKER_X, so
BEAKER_DESTROY instead of BEAKER_destroy. The old names are still
supported.
@bastelfreak bastelfreak changed the title Uppercase configuration environment variables Support uppercase configuration environment variables Mar 24, 2023
@bastelfreak bastelfreak merged commit 55bad9a into voxpupuli:master Mar 24, 2023
@ekohl ekohl deleted the support-upper-case-vars branch March 24, 2023 14:15
smortex added a commit to voxpupuli/voxpupuli.github.io that referenced this pull request Jul 12, 2023
Follow-up of:
voxpupuli/beaker-rspec#117

The old names or still supported but for consistency change them to the
new ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants