Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple rubocop violations #119

Merged
merged 8 commits into from
Mar 17, 2023
Merged

Fix multiple rubocop violations #119

merged 8 commits into from
Mar 17, 2023

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak self-assigned this Mar 17, 2023
@bastelfreak bastelfreak requested a review from ekohl March 17, 2023 11:09
@bastelfreak bastelfreak mentioned this pull request Mar 17, 2023
Merged
ekohl
ekohl reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Some small changes, but either way I think this is fine.

lib/beaker-rspec/helpers/serverspec.rb Outdated Show resolved Hide resolved
lib/beaker-rspec/helpers/serverspec.rb Show resolved Hide resolved
@bastelfreak bastelfreak requested a review from ekohl March 17, 2023 12:31
ekohl
ekohl approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekohl ekohl merged commit 7c64136 into voxpupuli:master Mar 17, 2023
@bastelfreak bastelfreak deleted the rubocop branch March 17, 2023 12:57
@smortex smortex changed the title fix multiple rubocop violations Fix multiple rubocop violations Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees

@bastelfreak bastelfreak

Labels
None yet
Projects
Implement Ruby 3.2 support
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @ekohl