Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 3.2 support #120

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Add Ruby 3.2 support #120

merged 1 commit into from
Mar 27, 2023

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak self-assigned this Mar 17, 2023
@bastelfreak
Copy link
Member Author

bastelfreak commented Mar 17, 2023 •
edited
Loading

also contains #119

@bastelfreak bastelfreak requested a review from ekohl March 17, 2023 11:16
@bastelfreak
Copy link
Member Author

needs some work in beaker-docker first

@ekohl
Copy link
Member

ekohl commented Mar 17, 2023

It is a legitimate failure due to Ruby 3.2 changes.

@ekohl
Copy link
Member

ekohl commented Mar 17, 2023

voxpupuli/beaker-docker#93 should address that.

@bastelfreak
Copy link
Member Author

after this is merged, I would also like to update the CI matrix to make the new job the new required one.

smortex
smortex approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@smortex smortex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. My only concern is that as far as I tested it on FreeBSD, Puppet 6/7 does not work with Ruby 3.2 because fast_gettext is currently broken due to the usage of untaint deprecated in ruby 2.7 (could not fix it correctly yet, so no PR at the moment).

Maybe defaulting to Ruby 3.2 will have some side effects with this for some of our gems and we will have to use 3.1 for them until this is fixed.

If we want consistency across all gems, I would rather suggest using 3.1 as the default version.

Edit: This was fixed a while ago. The FreeBSD dependency just need a refresh

@bastelfreak bastelfreak merged commit 9ca3fd3 into voxpupuli:master Mar 27, 2023
@bastelfreak bastelfreak deleted the ruby32 branch March 27, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

@ekohl ekohl Awaiting requested review from ekohl

Assignees

@bastelfreak bastelfreak

Labels
enhancement
Projects
Implement Ruby 3.2 support
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @ekohl @smortex