diff --git a/config_defaults.yml b/config_defaults.yml index adea84c5..5d396f06 100644 --- a/config_defaults.yml +++ b/config_defaults.yml @@ -2,8 +2,6 @@ # yamllint disable rule:line-length .github/workflows/ci.yml: excludes: [] - pidfile_workaround: false - additional_packages: '' acceptance_tests: true main_branches: ['main', 'master'] # PDK creates this diff --git a/moduleroot/.github/workflows/ci.yml.erb b/moduleroot/.github/workflows/ci.yml.erb index 801c2e1e..d9c15805 100644 --- a/moduleroot/.github/workflows/ci.yml.erb +++ b/moduleroot/.github/workflows/ci.yml.erb @@ -21,42 +21,16 @@ jobs: name: Puppet <%- if @configs['acceptance_tests'] && Dir[File.join(@metadata[:workdir], 'spec', 'acceptance', '**', '*_spec.rb')].any? -%> uses: voxpupuli/gha-puppet/.github/workflows/beaker.yml@v2 - with: - pidfile_workaround: '<%= @configs['pidfile_workaround'] %>' -<%- if @configs['with'] -%> -<%- @configs['with'].each do |k,v| -%> - <%= k %>: <%= v %> -<%- end -%> -<%- end -%> -<%- if @configs['unit_runs_on'] -%> - unit_runs_on: '<%= @configs['unit_runs_on'] %>' -<%- end -%> -<%- if @configs['beaker_facter'] -%> - beaker_facter: '<%= @configs['beaker_facter'] %>' -<%- end -%> -<%- if @configs['beaker_hypervisor'] -%> - beaker_hypervisor: '<%= @configs['beaker_hypervisor'] %>' -<%- end -%> -<%- if @configs['acceptance_runs_on'] -%> - acceptance_runs_on: '<%= @configs['acceptance_runs_on'] %>' -<%- end -%> <%- else -%> uses: voxpupuli/gha-puppet/.github/workflows/basic.yml@v2 -<%- if @configs.key?('rubocop') || !@configs['additional_packages'].empty? || @configs.key?('unit_runs_on') || @configs.key?('with') -%> - with: <%- end -%> <%- if @configs['with'] -%> + with: <%- @configs['with'].each do |k,v| -%> - <%= k %>: <%= v %> -<%- end -%> -<%- end -%> -<%- end -%> -<%- unless @configs['additional_packages'].empty? -%> - additional_packages: '<%= @configs['additional_packages'] %>' +<%- if v.is_a?(String) -%> + <%= k %>: '<%= v %>' +<%- else -%> + <%= k %>: <%= v %> <%- end -%> -<%- if @configs.key?('rubocop') -%> - rubocop: <%= @configs['rubocop'] %> <%- end -%> -<%- if Dir[File.join(@metadata[:workdir], 'spec', 'acceptance', '**', '*_spec.rb')].none? && @configs['unit_runs_on'] -%> - unit_runs_on: '<%= @configs['unit_runs_on'] %>' <%- end -%> diff --git a/moduleroot/.github/workflows/release.yml.erb b/moduleroot/.github/workflows/release.yml.erb index c4d598b8..4e2efb97 100644 --- a/moduleroot/.github/workflows/release.yml.erb +++ b/moduleroot/.github/workflows/release.yml.erb @@ -16,10 +16,16 @@ jobs: with: <%- if @configs['with'] -%> <%- @configs['with'].each do |k,v| -%> - <%= k %>: <%= v %> +<%- if v.is_a?(String) -%> + <%= k %>: '<%= v %>' +<%- else -%> + <%= k %>: <%= v %> <%- end -%> <%- end -%> +<%- end -%> +<%- unless @configs['with']&.has_key?('allowed_owner') -%> allowed_owner: '<%= @configs[:namespace] %>' +<%- end -%> secrets: # Configure secrets here: # https://docs.github.com/en/actions/security-guides/encrypted-secrets