Mongos as systemd service #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-haaks
commented
Mar 13, 2024
|
|
||
| if $service_manage { | ||
| if $facts['os']['family'] == 'RedHat' or $facts['os']['family'] == 'Suse' { | ||
| file { '/etc/sysconfig/mongos' : |
There was a problem hiding this comment.
This file is not mentioned in the service unit.
The content is set as Environment in the unit.
|
This change might break the mongos service in environments that are not on the latest 4.4 patch. |
|
Would be nice if someone with SLES environment could test this. ( not covered by beaker/github actions ) |
bastelfreak
reviewed
Mar 14, 2024
data/Debian-family.yaml
Outdated
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| mongodb::mongos::service_user: 'mongodb' | |||
| mongodb::mongos::service_group: 'mongodb' | |||
There was a problem hiding this comment.
Please add the missing newline at the end.
There was a problem hiding this comment.
Removed the unused init.d template as well
h-haaks
force-pushed
the
mongos-as-systemd-service
branch
from
8c5fbe7
to
8f8872a
Compare
witjoh
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Cleanup mongos setup by switching from old init.d script to systemd unit.
Bumping default repo version to 4.4 for redhat++ and default version for debian-10 to 4.4.29 was necessary to simplify the code.
As 4.4 is the oldest minor version supported by mongodb this should be OK.
This is my first PR related to #696