Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider cleanup part2 #706

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Provider cleanup part2 #706

merged 3 commits into from
Mar 21, 2024

Conversation

stevenpost
Copy link
Contributor

This PR removes more obsolete code.

Johan De Wit and others added 3 commits March 18, 2024 17:27
@stevenpost
Remove version check from provider
19385b1 
There is no difference in handling of the versions, since support for
pre-4.4 was dropped.
@stevenpost
Remove support for old versions from is_master fact
e4d77b1
@stevenpost
Fix typo in debug statement
7d53156
h-haaks
h-haaks approved these changes Mar 19, 2024
View reviewed changes
lib/facter/is_master.rb Show resolved Hide resolved
@stevenpost
Copy link
Contributor Author

I checked this again, turns out the old template for which this code was written, already got removed in fa66548 (way back in 2018).
The 'new' template was suffixed with '2.6.erb' because it was introduced for 2.6, earlier versions used the key-value config. See commit b1d2779.

This was referenced Mar 20, 2024
Closed
Merged
@h-haaks
Copy link
Contributor

h-haaks commented Mar 20, 2024

I do agree after my irb testing with YAML.load_file.
It's just strage formated yaml with dots in keynames which is completety different from the package providet file and mongodb docs.

@h-haaks
Copy link
Contributor

h-haaks commented Mar 21, 2024

@stevenpost could you please merge this?

@h-haaks h-haaks merged commit 1c6c5a2 into voxpupuli:master Mar 21, 2024
12 checks passed
@stevenpost stevenpost deleted the provider_cleanup_part2 branch March 21, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-haaks h-haaks h-haaks approved these changes

@witjoh witjoh witjoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenpost @h-haaks @witjoh