Use edge-filepath module to create parent directories for NFS exports. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derdanne
requested changes
May 31, 2022
metadata.json
Outdated
| @@ -13,6 +13,7 @@ | |||
| {"name":"puppetlabs/transition","version_requirement":">= 0.1.0 < 2.0.0"}, | |||
| {"name":"herculesteam/augeasproviders_core","version_requirement":">= 2.1.5 < 4.0.0"}, | |||
| {"name":"herculesteam/augeasproviders_shellvar","version_requirement":">= 1.2.0 < 5.0.0"} | |||
There was a problem hiding this comment.
Here should be a trailing comma
There was a problem hiding this comment.
Can you also please fix the tests?
I'm afraid I don't know how to make rspec tests. Would anything really need to be changed as all I've done is ensure that the parent directories of the export get created.
There was a problem hiding this comment.
@derdanne, the tests have been broken for a while -- at least since I created a fork. I do not know what to do to fix them. Can you advise just a little bit to get me started?
bschonec
force-pushed
the
create_parent_directories_for_nfs_exports
branch
from
7b4719e
to
8342be5
Compare
bschonec
force-pushed
the
create_parent_directories_for_nfs_exports
branch
from
21b3044
to
61af3a1
Compare
bschonec
force-pushed
the
create_parent_directories_for_nfs_exports
branch
6 times, most recently
from
e413c48
to
3ec4ce9
Compare
bschonec
force-pushed
the
create_parent_directories_for_nfs_exports
branch
from
10f1536
to
1a02fb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the directory creation to the edgej-filepath module. One side effect of switching to this module is that the selinux_ignore_defaults attribute of the file resource isn't supported. Since it's necessary to set the SELinux context via Puppet on an NFS export anyway, I think this feature won't be missed.