proxysql 2.1 and 2.3 support #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mmm ... looks like I broke the testing that was expecting to see the purging of the old versions. So -- please let me know which path you would like me to take: A. remove the cleanup of old versions like I've done (but I'll go back and fix the tests) or B. add back the cleanup of other versions and also adjust the tests accordingly. I'm fine with either but wanted to ask first. |
|
You know what -- after sleeping on it, it would be easy to put back that old version purge. I'll do that -- please don't accept this as is. =) |
|
There we go. If you're cool with it, ready for merging from my end. |
ekohl
approved these changes
Apr 28, 2022
cegeka-jenkins
pushed a commit
to cegeka/puppet-proxysql
that referenced
this pull request
Aug 22, 2023
Newer proxysql support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds very simple support for newer ProxySQL versions. In my case I'm using 2.3 but I added the ones in between. One big caveat is that I removed the cleanup of old versions in the process. Frankly.. because it was going to be incredibly ugly code to clean up. That said if you feel strongly about that, I can add it back.
It also adjusts the accepted regex patterns because stuff like: ^.*$ was not working because it had no word characters.