Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spiped service should subscribe to keyfile #2

Closed
alexjfisher opened this issue Jun 10, 2019 · 4 comments · Fixed by #11
Closed

spiped service should subscribe to keyfile #2

alexjfisher opened this issue Jun 10, 2019 · 4 comments · Fixed by #11

Comments

@alexjfisher
Copy link
Member

Updating the secret, doesn't restart the service. It'd be great if it did.

Let me know if you're accepting PRs. (This module hasn't been updated in a while, so perhaps you've moved on).

Thanks,
Alex

@alexjfisher
Copy link
Member Author

@chriskuehl Hi! I thought I'd reach out as I've been making some increasingly heavy modifications to this module in my own fork. Next I plan to add some unit and acceptance tests.

If you're still using this module and would like to keep making your own forge releases, I could open PRs. If not, I'm happy to migrate and release my fork under Vox Pupuli's puppet namespace. (This gives me access to their excellent tooling, sponsored travis slots etc.)

Or if you're happy to have your fork maintained by the community, you could consider migrating it directly to the Vox Pupuli project. You'd keep merge access in this scenario.

If you'd like to chat about any of these options, I'm usually around on the #voxpupuli freenode IRC channel or on the puppet-community slack #voxpupuli channel.

Thanks,
Alex (Vox Pupuli PMC member)

@chriskuehl
Copy link
Collaborator

Hey @alexjfisher, sorry I missed your first ping -- somehow I was not "watching" this repo!

I'm happy to accept PRs, but as you noticed, I'm no longer personally using this module so am not really actively maintaining it. If you're interested in maintaining a fork, that sounds great to me. I'm also happy to give out commit access to this repo, but it sounds like Vox Pupuli might be a better idea.

Let me know if you need anything from me to get the repo moved over!

@alexjfisher
Copy link
Member Author

I've sent you an invite to join the Vox github org. This should allow you to transfer the repository over. We find this is better for users than us forking a repo.

I'll make sure you keep commit access (although we do still ask that people don't merge their own PRs before they've been reviewed etc.). If you're interested in helping with any of our other modules, we're always looking for volunteers. Just let me know. :)

@chriskuehl
Copy link
Collaborator

Should be transferred now!

alexjfisher added a commit to alexjfisher/puppet-spiped that referenced this issue Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants