use confine instead of if statement

voxpupuli · Jun 21, 2024 · 408dec4 · 408dec4
1 parent 7cf05de
commit 408dec4
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/lib/facter/vault_version.rb b/lib/facter/vault_version.rb
@@ -5,11 +5,10 @@
 # Purpose: Retrieve vault version if installed
 #
 Facter.add(:vault_version) do
+  confine {Facter::Util::Resolution.which('vault')}
   setcode do
-    if Facter::Util::Resolution.which('vault')
-      vault_server_version_output = Facter::Util::Resolution.exec('vault version')
-      match = vault_server_version_output.match(%r{Vault v(\d+\.\d+\.\d+)})
-      match&.captures&.first
-    end
+    vault_server_version_output = Facter::Util::Resolution.exec('vault version')
+    match = vault_server_version_output.match(%r{Vault v(\d+\.\d+\.\d+)})
+    match&.captures&.first
   end
 end