This repository has been archived by the owner on Jan 29, 2022. It is now read-only.
Move repo_user/name parsing to webhook_json_parser #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Nov 2, 2017
lib/parsers/webhook_json_parser.rb
Outdated
| @data['repository']['name'] | ||
| end | ||
| # TODO: Bitbucket, Stash/Bitbucket Server, Gitlab, TFS | ||
| nil |
There was a problem hiding this comment.
This should be in an else branch of the case statement. Same for repo_user below.
There was a problem hiding this comment.
That's what I started with, but rubocop hates me. Redundant 'else'-clause
There was a problem hiding this comment.
They can be used as the 'prefix'
There was a problem hiding this comment.
Sorry, it was obviously wrong before unless I added some returns.
alexjfisher
force-pushed
the
refactor_repo_name
branch
from
4db317f
to
40d3e78
Compare
dhollinger
approved these changes
Nov 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.