Skip to content
This repository has been archived by the owner on Jan 29, 2022. It is now read-only.

Fix bug and add unit tests for stash payload #17

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Fix bug and add unit tests for stash payload #17

merged 1 commit into from
Nov 3, 2017

Conversation

alexjfisher
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+7.3%) to 32.184% when pulling 365f5fd on alexjfisher:add_stash_fixtures_and_tests into 10b7cf9 on voxpupuli:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+7.3%) to 32.184% when pulling 29a36fb on alexjfisher:add_stash_fixtures_and_tests into 10b7cf9 on voxpupuli:master.

alexjfisher
alexjfisher commented Nov 3, 2017
View reviewed changes
lib/parsers/webhook_json_parser.rb
@@ -91,7 +91,7 @@ def deleted?
when 'gitlab'
@data['after'] == '0000000000000000000000000000000000000000'
when 'stash'
@data['refChanges'][0]['type'] == 'DELETED'
@data['refChanges'][0]['type'] == 'DELETE'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful tests are useful. :)

@dhollinger dhollinger merged commit 6d0943c into voxpupuli:master Nov 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexjfisher @coveralls @dhollinger