Skip to content

Commit

Permalink
Merge pull request #188 from bastelfreak/rel500
Browse files Browse the repository at this point in the history
Release 5.0.0
  • Loading branch information
bastelfreak committed Jul 8, 2024
2 parents b2215f6 + 2a8d24b commit 56c2f65
Show file tree
Hide file tree
Showing 3 changed files with 58 additions and 13 deletions.
57 changes: 45 additions & 12 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,25 @@
# Changelog

## [5.0.0](https://github.com/voxpupuli/rspec-puppet-facts/tree/5.0.0) (2024-07-04)

[Full Changelog](https://github.com/voxpupuli/rspec-puppet-facts/compare/4.0.0...5.0.0)

**Breaking changes:**

- Switch to FacterDB 3 / drop legacy facts [\#187](https://github.com/voxpupuli/rspec-puppet-facts/pull/187) ([bastelfreak](https://github.com/bastelfreak))

**Implemented enhancements:**

- Deprecate symbolized facts [\#193](https://github.com/voxpupuli/rspec-puppet-facts/pull/193) ([bastelfreak](https://github.com/bastelfreak))

**Fixed bugs:**

- handle stringified facterversion properly [\#191](https://github.com/voxpupuli/rspec-puppet-facts/pull/191) ([bastelfreak](https://github.com/bastelfreak))

**Merged pull requests:**

- Update voxpupuli-rubocop requirement from ~\> 2.7.0 to ~\> 2.8.0 [\#192](https://github.com/voxpupuli/rspec-puppet-facts/pull/192) ([dependabot[bot]](https://github.com/apps/dependabot))

## [4.0.0](https://github.com/voxpupuli/rspec-puppet-facts/tree/4.0.0) (2024-06-10)

[Full Changelog](https://github.com/voxpupuli/rspec-puppet-facts/compare/3.0.0...4.0.0)
Expand Down Expand Up @@ -27,28 +47,41 @@

**symbolized facts deprecation**

With the release of rspec-puppet-facts 4.0.0 we will remove support for symbolized facts. At the moment people typically use this in their unit files:
With the release of rspec-puppet-facts 6.0.0 we will remove support for symbolized facts. At the moment people typically use this in their unit files:

```ruby
case facts[:os]['name']
when 'Archlinux'
context 'on Archlinux' do
it { is_expected.to contain_package('borg') }
on_supported_os.each do |os, os_facts|
case os_facts[:os]['name']
when 'Archlinux'
context 'on Archlinux' do
it { is_expected.to contain_package('borg') }
end
when 'Ubuntu'
end
when 'Ubuntu'
end
```

For history reasons the first level of facts were symbols. You will have to update it to strings with the 4.0.0 release:
For history reasons the first level of facts were symbols. You will have to update it to strings with the 6.0.0 release:

```ruby
case facts['os']['name']
when 'Archlinux'
context 'on Archlinux' do
it { is_expected.to contain_package('borg') }
on_supported_os.each do |os, os_facts|
case os_facts['os']['name']
when 'Archlinux'
context 'on Archlinux' do
it { is_expected.to contain_package('borg') }
end
when 'Ubuntu'
end
when 'Ubuntu'
end
```

As an alternative you can configure the old behaviour:

```ruby
RSpec.configure do |c|
c.facterdb_string_keys = false
end
```

**Breaking changes:**

Expand Down
12 changes: 12 additions & 0 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,18 @@ else
gem_version = Gem::Specification.load("#{config.project}.gemspec").version
config.future_release = gem_version
end

# Workaround for https://github.com/github-changelog-generator/github-changelog-generator/issues/715
require 'rbconfig'
if RbConfig::CONFIG['host_os'].include?('linux')
task :changelog do
puts 'Fixing line endings...'
changelog_file = File.join(__dir__, 'CHANGELOG.md')
changelog_txt = File.read(changelog_file)
new_contents = changelog_txt.gsub("\r\n", "\n")
File.open(changelog_file, 'w') { |file| file.puts new_contents }
end
end
end

begin
Expand Down
2 changes: 1 addition & 1 deletion lib/rspec-puppet-facts/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ module RspecPuppetFacts
# This module contains the current version constant
module Version
# The current version of this gem
STRING = '4.0.0'
STRING = '5.0.0'
end
end

0 comments on commit 56c2f65

Please sign in to comment.