Use a single FacterDB.get_facts call #158
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
==========================================
- Coverage 95.20% 94.15% -1.06%
==========================================
Files 2 2
Lines 167 171 +4
==========================================
+ Hits 159 161 +2
- Misses 8 10 +2
☔ View full report in Codecov by Sentry. |
ekohl
force-pushed
the
single-get-facts-call
branch
from
ae76698
to
f7a1e25
Compare
|
Updated to use voxpupuli/facterdb#282. |
The major cost is FacterDB.get_facts. Instead of calling it once for every OS version this instead calls it once with a complex filter. It then uses JGrep to simulate another smaller DB and futher query that. In my non-scientific test this reduces the load time of puppet-example from 3.5 to 2.5 seconds.
ekohl
force-pushed
the
single-get-facts-call
branch
from
f7a1e25
to
70f4c33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major cost is FacterDB.get_facts. Instead of calling it once for every OS version this instead calls it once with a complex filter. It then uses JGrep to simulate another smaller DB and futher query that.
In my non-scientific test this reduces the load time of puppet-example from 3.5 to 2.5 seconds.
This is VERY hacky and duplicates logic from FacterDB which it really should not do. There is also overhead of serializing to JSON, loading that back and doing symbol conversion. It may be possible to use
JGrep.filter_json, but that probably fails on the symbol keys. If FacterDB.get_facts could return string keys all of that would be redundant.