From 9cd8ff0ab1c2ebaab556dd7411d5a3b9e2ad307f Mon Sep 17 00:00:00 2001 From: Hiroshi Tanaka Date: Tue, 26 Apr 2022 18:31:23 +0900 Subject: [PATCH 1/3] Fix adRenderSucceededEvent. --- modules/fluctAnalyticsAdapter.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/fluctAnalyticsAdapter.js b/modules/fluctAnalyticsAdapter.js index 1740dd92797..ff57105aa41 100644 --- a/modules/fluctAnalyticsAdapter.js +++ b/modules/fluctAnalyticsAdapter.js @@ -88,7 +88,7 @@ const browsiEventListener = (event) => { const divId = event.slot.getSlotElementId(); if (isBrowsiId(divId)) { const auction = find(Object.values(cache.auctions), auction => - auction.adUnitCodes.every(adUnitCode => adUnitCode === divId)); + auction.adUnitCodes.every(adUnitCode => adUnitCode === divId)) || {}; sendMessage(auction.auctionId); } } @@ -169,7 +169,7 @@ let fluctAnalyticsAdapter = Object.assign( /** @type {{ adId: string, bid: Bid, doc: any }} */ let adRenderSucceededEvent = args; let { bid: { auctionId, requestId } } = adRenderSucceededEvent; - Object.assign(cache.auctions[auctionId].bids[requestId], bidWonEvent, { + Object.assign(cache.auctions[auctionId].bids[requestId], adRenderSucceededEvent, { noBid: false, prebidWon: true, bidWon: true, From 1a1a1d46ea97bf0247eb50123789d1a12be13a7b Mon Sep 17 00:00:00 2001 From: Hiroshi Tanaka Date: Tue, 26 Apr 2022 18:37:14 +0900 Subject: [PATCH 2/3] Fix browsiEventListener behavior. --- modules/fluctAnalyticsAdapter.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/modules/fluctAnalyticsAdapter.js b/modules/fluctAnalyticsAdapter.js index ff57105aa41..97eb37f7439 100644 --- a/modules/fluctAnalyticsAdapter.js +++ b/modules/fluctAnalyticsAdapter.js @@ -87,9 +87,8 @@ export const convertReplicatedAdUnit = (_adUnit, adUnits = $$PREBID_GLOBAL$$.adU const browsiEventListener = (event) => { const divId = event.slot.getSlotElementId(); if (isBrowsiId(divId)) { - const auction = find(Object.values(cache.auctions), auction => - auction.adUnitCodes.every(adUnitCode => adUnitCode === divId)) || {}; - sendMessage(auction.auctionId); + const auction = find(Object.values(cache.auctions), auction => auction.adUnitCodes.every(adUnitCode => adUnitCode === divId)); + auction && sendMessage(auction.auctionId); } } From c3f4111b646d09ec614ca8456ac0483639040a7e Mon Sep 17 00:00:00 2001 From: Hiroshi Tanaka Date: Tue, 26 Apr 2022 19:01:36 +0900 Subject: [PATCH 3/3] Unmerge adRenderSucceeded event object. --- modules/fluctAnalyticsAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/fluctAnalyticsAdapter.js b/modules/fluctAnalyticsAdapter.js index 97eb37f7439..1f6c0a939c5 100644 --- a/modules/fluctAnalyticsAdapter.js +++ b/modules/fluctAnalyticsAdapter.js @@ -168,7 +168,7 @@ let fluctAnalyticsAdapter = Object.assign( /** @type {{ adId: string, bid: Bid, doc: any }} */ let adRenderSucceededEvent = args; let { bid: { auctionId, requestId } } = adRenderSucceededEvent; - Object.assign(cache.auctions[auctionId].bids[requestId], adRenderSucceededEvent, { + Object.assign(cache.auctions[auctionId].bids[requestId], { noBid: false, prebidWon: true, bidWon: true,