Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement vhost_traffic_status_upstream_no_cache filter #194

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

heikkiorsila
Copy link

This enables monitoring upstream backend events that are configured not to
use cache.

Add the following line to nginx config to create a group:

    vhost_traffic_status_filter_upstream_no_cache "NO_CACHE";

@vozlt
Copy link
Owner

vozlt commented Sep 4, 2022

Thanks for the pull request for improvement. But do you need to put non-cached statistics inside serverZones? As far as I know you can already use the information(miss, bypass, expired, stale, updating, revalidated, hit, scarce) in serverZones to calculate statistics for non-cached items. I think it is correct to calculate it through a 3rd party program.

@vozlt vozlt requested review from SuperQ and u5surf September 4, 2022 16:04
Copy link
Collaborator

@u5surf u5surf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @heikkiorsila
Thanks feature PR. We didn’t find obviously what to expect on this feature. Because I also couldn’t find any differences between vhost_traffic_status_zone and this feature.

Can you add some tests or share your scenarios to explain your expectation on this feature? It is necessary for us and our users to make sense this feature properly.

vozlt and others added 3 commits October 3, 2022 09:40
…g the ngx_http_vhost_traffic_status_display_get_size() function
* To reduce the ci build time
This enables monitoring upstream backend events that are configured not to
use cache.

Add the following line to nginx config to create a group:

        vhost_traffic_status_filter_upstream_no_cache "NO_CACHE";
@u5surf
Copy link
Collaborator

u5surf commented Oct 18, 2022

@ypcs Hi, Thanks following about this PR.

We almost agree with what @vozlt said the below

But do you need to put non-cached statistics inside serverZones? As far as I know you can already use the information(miss, bypass, expired, stale, updating, revalidated, hit, scarce) in serverZones to calculate statistics for non-cached items. I think it is correct to calculate it through a 3rd party program.

Do you have any another reasons that the feature is necessary for this modules?
And can you add some tests or share your expected scenarios to explain the necessity on this feature?
We'll judge based on it whether this PR should merge or not.

@ypcs
Copy link

ypcs commented Oct 19, 2022

Hi. We're currently evaluating if this is necessary, I'll post update later, and we'll provide tests then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants