Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3.12 #216

Closed
purva-thakre opened this issue Oct 31, 2023 · 6 comments
Closed

Upgrade to Python 3.12 #216

purva-thakre opened this issue Oct 31, 2023 · 6 comments
Assignees

Comments

@purva-thakre
Copy link
Collaborator

purva-thakre commented Oct 31, 2023

Newest version of Python was released on Oct 2, 23. https://www.python.org/downloads/release/python-3120/

It might be good to make changes in toqito to allow Python 3.12. As tested in #215, we do need to wait for numpy to upgrade to the newer version before we make changes to this repo.

Currently, a Github workflow's virtual environment is installing numpy 1.25.2 but numpy 1.26 released in Sep 2023 has Python 3.12 support. Maybe poetry is forcing an older version of numpy due to other package dependencies.

https://pypi.org/project/numpy/

Note: an easy way to fix the build error in #215 would be to pin a higher numpy version.

@purva-thakre
Copy link
Collaborator Author

Maybe poetry is forcing an older version of numpy due to other package dependencies.

This might be fixed by #218

@purva-thakre
Copy link
Collaborator Author

As stated in #354 (comment), we have to wait for cvxopt to be compatible with 3.12 then only we can upgrade to a newer version of python.

@Bchass
Copy link
Contributor

Bchass commented Jan 8, 2024

3.12 now passes: Bchass#2

@purva-thakre
Copy link
Collaborator Author

@Bchass Feel free to add a PR for this.

I should have had a test PR up after #409. Looks like we did not need to wait for cvxopt or cvxpy.

@purva-thakre
Copy link
Collaborator Author

Fixed by #413

@purva-thakre
Copy link
Collaborator Author

@Bchass When you make a pull request, use one of the keywords allowed by github (link below). This will automatically close the referenced issue after the PR is merged.

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants