Fixesapply_channel
#155
Merged
Fixesapply_channel
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. A Choi representation of the input quantum channel is used. The code was originally ported from QETLAB but `order=F` to match MATLAB convention was omitted while reshaping a matrix. 2. A Kraus representation of a completely positive channel is used. Afterwards issues with: 1. `partial_channel` 2. documentation errors, and 3. test cases where a wrong answer was being verified were identified and fixed.
|
It is wonderful to see you here again, @georgios-ts ! As usual, your contributions are great, and the One minor point: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit starts by fixing
apply_channelwhen:ported from QETLAB but
order="F"to match MATLAB convention was omittedwhile reshaping a matrix.
Afterwards issues with:
partial_channelwere identified and fixed.
Fixes #144.
Status