Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort imports using isort #192

Closed
wants to merge 0 commits into from
Closed

Sort imports using isort #192

wants to merge 0 commits into from

Conversation

purva-thakre
Copy link
Collaborator

@purva-thakre purva-thakre commented Sep 12, 2023

Description

cd toqito
toqito$ isort .

Wanted to give this a try. Will double-check all changes before marking this as ready to go.

It might be perhaps preferable to make changes in one file-checking the tests before moving onto the next file instead.
188 tests are failing right now.
https://github.com/purva-thakre/toqito/actions/runs/6153261890/job/16696846830#step:5:17031

Edit: Specifying the full path as in this file, does fix a previous error in this file. What did isort change here?

Todos

Notable points that this PR has either accomplished or will accomplish.

Questions

  • Question1

Status

  • Ready to go

@vprusso
Copy link
Owner

vprusso commented Sep 12, 2023

Thanks for opening the PR, @purva-thakre! If I can lend a hand, let me know!

@purva-thakre
Copy link
Collaborator Author

Github closed this automatically when I force pushed my undo of initial commit. Will reopen later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants