Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydocstyle Errors #200

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Pydocstyle Errors #200

merged 6 commits into from
Oct 16, 2023

Conversation

purva-thakre
Copy link
Collaborator

Fixes #199

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #200 (4155796) into master (1fc9874) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master    #200   +/-   ##
======================================
  Coverage    96.0%   96.0%           
======================================
  Files         146     146           
  Lines        3019    3019           
  Branches      725     725           
======================================
  Hits         2899    2899           
  Misses         76      76           
  Partials       44      44           
Files Coverage Δ
...o/channel_metrics/completely_bounded_trace_norm.py 88.8% <ø> (ø)
toqito/matrix_ops/inner_product.py 100.0% <ø> (ø)
toqito/matrix_ops/outer_product.py 100.0% <ø> (ø)
toqito/matrix_props/is_diagonally_dominant.py 100.0% <ø> (ø)
toqito/matrix_props/trace_norm.py 100.0% <ø> (ø)
toqito/nonlocal_games/xor_game.py 100.0% <100.0%> (ø)
toqito/state_opt/state_exclusion.py 100.0% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@purva-thakre purva-thakre marked this pull request as ready for review October 16, 2023 01:49
@purva-thakre
Copy link
Collaborator Author

purva-thakre commented Oct 16, 2023

@vprusso This one is ready for a review.

BTW you might want to change the merge conditions (in project settings) to at least one approval before merging a PR.
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches#require-pull-request-reviews-before-merging

Copy link
Owner

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! LGTM! Merge when ready!

@purva-thakre purva-thakre merged commit 4563da0 into master Oct 16, 2023
4 checks passed
@purva-thakre purva-thakre deleted the pydocstyle_errors branch October 16, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pydocstyle errors
2 participants