Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing is mutually orthogonal function. #250

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

vprusso
Copy link
Owner

@vprusso vprusso commented Nov 17, 2023

  • Reduces runtime of check from O(n^2) to an O(n) approach
  • Adding additional test cases.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a303507) 98.0% compared to head (c516cf6) 98.0%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #250     +/-   ##
========================================
- Coverage    98.0%   98.0%   -0.1%     
========================================
  Files         287     287             
  Lines        6831    6829      -2     
  Branches      772     768      -4     
========================================
- Hits         6698    6696      -2     
  Misses         90      90             
  Partials       43      43             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vprusso vprusso merged commit a3bfa73 into master Nov 18, 2023
3 checks passed
@vprusso vprusso deleted the optimize-is-mutually-orthogonal-function branch November 18, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants