Fixing bug in state exclusion code. #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
========================================
- Coverage 98.1% 98.1% -0.1%
========================================
Files 295 295
Lines 6927 6926 -1
Branches 773 772 -1
========================================
- Hits 6796 6795 -1
Misses 90 90
Partials 41 41 ☔ View full report in Codecov by Sentry. |
purva-thakre
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
pylint flagged some things.
************* Module state_opt.state_exclusion
toqito/state_opt/state_exclusion.py:147:4: W0621: Redefining name 'pure_to_mixed' from outer scope (line 5) (redefined-outer-name)
toqito/state_opt/state_exclusion.py:[14](https://github.com/vprusso/toqito/actions/runs/7014095530/job/19081277332#step:6:15)7:4: W0404: Reimport 'pure_to_mixed' (imported line 5) (reimported)
toqito/state_opt/state_exclusion.py:147:4: C04[15](https://github.com/vprusso/toqito/actions/runs/7014095530/job/19081277332#step:6:16): Import outside toplevel (toqito.state_ops.pure_to_mixed) (import-outside-toplevel)
|
Thanks for flagging those! Fixed and merging now. Thanks for the quick review, @purva-thakre ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a silly bug that I patched for
state_exclusion.