Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add white background to logo #466

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Add white background to logo #466

merged 5 commits into from
Feb 9, 2024

Conversation

purva-thakre
Copy link
Collaborator

@purva-thakre purva-thakre commented Feb 6, 2024

Description

Related to the work introduced in #416.

This PR makes sure the toqito logo is visible in dark mode of docs.

Inverted color version of the logo does not look that good. Could be tackled later in another PR as we want to be consistent with the color theme of wagtail. Added these images to try a customized version of CSS where the logo image is switched depending on which theme is being used: light/dark.

https://www.reddit.com/r/tailwindcss/comments/kd9czo/comment/gfw0zxb/?utm_source=share&utm_medium=web2x&context=3

Or we don't need to tackle this. Use the image with a white background.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • TODO 1

Questions

  • Question1

Status

  • Ready to go

README.md Outdated
@@ -1,4 +1,4 @@
# ![logo](./docs/figures/logo.svg "logo")
# ![logo](./docs/figures/logo.png "logo")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@purva-thakre purva-thakre changed the title Add background to logo Add white background to logo Feb 6, 2024
@purva-thakre purva-thakre marked this pull request as ready for review February 6, 2024 21:17
@purva-thakre
Copy link
Collaborator Author

marking this ready for review even though I have 1 item I need to resolve.

I can't use a permalink to fix that comment because the new images I want to use are in this PR.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0e7e7e) 98.0% compared to head (6ef24a2) 98.1%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #466   +/-   ##
======================================
  Coverage    98.0%   98.1%           
======================================
  Files         158     160    +2     
  Lines        3074    3107   +33     
  Branches      739     749   +10     
======================================
+ Hits         3015    3048   +33     
  Misses         37      37           
  Partials       22      22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
@Bchass
Copy link
Contributor

Bchass commented Feb 8, 2024

Did the inverted colors not work?

@purva-thakre
Copy link
Collaborator Author

purva-thakre commented Feb 8, 2024

yeah, they don't really look as clean as the current logo. Which is why I decided to remove them.

You can take a look at this commit: c663960

I think we can just keep the current logo for both light/dark modes. I added a white background for this reason.

@purva-thakre
Copy link
Collaborator Author

@vprusso Can I go ahead and merge this? I think merging this PR would be helpful for the WIP changes in #416.

I think I figured out why the image on the PyPI page is broken. This PR handles it and hopefully we will see the logo after a later release.

image

We can worry about customizing the logo for the new theme later.

@vprusso
Copy link
Owner

vprusso commented Feb 9, 2024

@vprusso Can I go ahead and merge this? I think merging this PR would be helpful for the WIP changes in #416.

I think I figured out why the image on the PyPI page is broken. This PR handles it and hopefully we will see the logo after a later release.

image

We can worry about customizing the logo for the new theme later.

Yep, merge away!

@purva-thakre purva-thakre merged commit e0e89f9 into master Feb 9, 2024
15 checks passed
@purva-thakre purva-thakre deleted the svg_to_png branch February 9, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants