-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add white background to logo #466
Conversation
README.md
Outdated
@@ -1,4 +1,4 @@ | |||
# ![logo](./docs/figures/logo.svg "logo") | |||
# ![logo](./docs/figures/logo.png "logo") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this link to fix broken image in PyPI.
marking this ready for review even though I have 1 item I need to resolve. I can't use a permalink to fix that comment because the new images I want to use are in this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #466 +/- ##
======================================
Coverage 98.0% 98.1%
======================================
Files 158 160 +2
Lines 3074 3107 +33
Branches 739 749 +10
======================================
+ Hits 3015 3048 +33
Misses 37 37
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Did the inverted colors not work? |
yeah, they don't really look as clean as the current logo. Which is why I decided to remove them. You can take a look at this commit: c663960 I think we can just keep the current logo for both light/dark modes. I added a white background for this reason. |
@vprusso Can I go ahead and merge this? I think merging this PR would be helpful for the WIP changes in #416. I think I figured out why the image on the We can worry about customizing the logo for the new theme later. |
Yep, merge away! |
Description
Related to the work introduced in #416.
This PR makes sure the
toqito
logo is visible in dark mode of docs.Inverted color version of the logo does not look that good. Could be tackled later in another PR as we want to be consistent with the color theme of
wagtail
. Added these images to try a customized version of CSS where the logo image is switched depending on which theme is being used: light/dark.https://www.reddit.com/r/tailwindcss/comments/kd9czo/comment/gfw0zxb/?utm_source=share&utm_medium=web2x&context=3
Or we don't need to tackle this. Use the image with a white background.
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Status