Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toml dependency groups #585

Merged
merged 7 commits into from
May 16, 2024
Merged

Add toml dependency groups #585

merged 7 commits into from
May 16, 2024

Conversation

purva-thakre
Copy link
Collaborator

Description

Related to #456

Changes

Notable changes that this PR has either accomplished or will accomplish. Feel free to add more lines to the itemized list
below.

  • Change 1

Checklist

Before marking your PR ready for review, make sure you checked the following locally. If this is your first PR, you might be notified of some workflow failures after a maintainer has approved the workflow jobs to be run on your PR.

Additional information is available in the documentation.

  • Use ruff and pylint for errors related to code style and formatting.
  • Verify all previous and newly added unit tests pass in pytest.
  • Check the documentation build does not lead to any failures. Sphinx build can be checked locally for any failures related to your PR
  • Use linkcheck to check for broken links in the documentation
  • Use doctest to verify the examples in the function docstrings work as expected.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.1%. Comparing base (39bad5d) to head (f58423d).
Report is 260 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #585   +/-   ##
======================================
  Coverage    98.1%   98.1%           
======================================
  Files         162     162           
  Lines        3108    3108           
  Branches      760     760           
======================================
  Hits         3050    3050           
  Misses         37      37           
  Partials       21      21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purva-thakre purva-thakre marked this pull request as ready for review May 16, 2024 15:52
@purva-thakre purva-thakre requested a review from vprusso May 16, 2024 16:11
@vprusso
Copy link
Owner

vprusso commented May 16, 2024

Nice. Think this arrangement of the toml file is much more streamlined. Nice work, LGTM MWR! 🚀

@purva-thakre purva-thakre merged commit a67a323 into master May 16, 2024
34 checks passed
@purva-thakre purva-thakre deleted the simplify_toml branch May 16, 2024 17:58
@purva-thakre purva-thakre added this to the v1.0.8 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants