-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue #401 #606
Fix for Issue #401 #606
Conversation
…also added to articles.bib
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #606 +/- ##
======================================
Coverage 98.1% 98.1%
======================================
Files 162 162
Lines 3108 3108
Branches 760 760
======================================
Hits 3050 3050
Misses 37 37
Partials 21 21 ☔ View full report in Codecov by Sentry. |
docs/articles.bib
Outdated
@@ -90,6 +90,19 @@ @article{Breuer_2006_Optimal | |||
|
|||
|
|||
#Last name begins with C | |||
@article{Cavalcanti_2015_Detection, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Roshan-Thomas Thank you for this PR!
Could you please make sure the keys are arranged alphabetically? You have placed them in the right spot but a key beginning with cav
should be placed after cab
and so on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I have fixed the issue in the following commit. Hope that fixes everything :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @Roshan-Thomas. Feel free to comment on the linked issue so that the issue can be assigned to you for the bounty bot.
@vprusso Do you want to take a look at this before we merge it?
Looks good on my end as well! Thank you for the contribution, @Roshan-Thomas and thank you for the additional help in guiding the PR, @purva-thakre ! Feel free to merge when ready and congrats, @Roshan-Thomas ! |
Congrats on the bounty @Roshan-Thomas ! |
Description
References in the tutorials have been fixed as per the guidelines in #401. Fix is part of the Unitary Hack 2024.
Fixes #401
Changes
The changes are listed below.