Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #401 #606

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

Roshan-Thomas
Copy link
Contributor

@Roshan-Thomas Roshan-Thomas commented May 30, 2024

Description

References in the tutorials have been fixed as per the guidelines in #401. Fix is part of the Unitary Hack 2024.

Fixes #401

Changes

The changes are listed below.

  • The references have automatically been updated in each tutorial using the Spinx tool.
  • Some references in the tutorials were missing from the articles.bib file, so I have added them using the same style as recommended.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.1%. Comparing base (220b94f) to head (a3754b8).
Report is 272 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #606   +/-   ##
======================================
  Coverage    98.1%   98.1%           
======================================
  Files         162     162           
  Lines        3108    3108           
  Branches      760     760           
======================================
  Hits         3050    3050           
  Misses         37      37           
  Partials       21      21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -90,6 +90,19 @@ @article{Breuer_2006_Optimal


#Last name begins with C
@article{Cavalcanti_2015_Detection,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Roshan-Thomas Thank you for this PR!

Could you please make sure the keys are arranged alphabetically? You have placed them in the right spot but a key beginning with cav should be placed after cab and so on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have fixed the issue in the following commit. Hope that fixes everything :)

Copy link
Collaborator

@purva-thakre purva-thakre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Roshan-Thomas. Feel free to comment on the linked issue so that the issue can be assigned to you for the bounty bot.

@vprusso Do you want to take a look at this before we merge it?

@Roshan-Thomas Roshan-Thomas mentioned this pull request May 31, 2024
3 tasks
@vprusso
Copy link
Owner

vprusso commented May 31, 2024

Looks good on my end as well! Thank you for the contribution, @Roshan-Thomas and thank you for the additional help in guiding the PR, @purva-thakre !

Feel free to merge when ready and congrats, @Roshan-Thomas !

@purva-thakre purva-thakre merged commit a6fe497 into vprusso:master May 31, 2024
18 checks passed
@purva-thakre
Copy link
Collaborator

Congrats on the bounty @Roshan-Thomas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

References in tutorials
3 participants