Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Cyclic Permutation to Cyclic Permutation Matrix #682

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

FabienGhd
Copy link
Contributor

@FabienGhd FabienGhd commented Jul 14, 2024

Hi,

This PR resolves #676.
Renamed files and functions to add "matrix" for consistency. Updated the relevant tests accordingly.

Best,
Fabien

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.7%. Comparing base (62ad845) to head (f5490c2).
Report is 284 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #682   +/-   ##
======================================
  Coverage    97.7%   97.7%           
======================================
  Files         166     166           
  Lines        3250    3250           
  Branches      795     795           
======================================
  Hits         3177    3177           
  Misses         48      48           
  Partials       25      25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@purva-thakre purva-thakre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FabienGhd!

This PR looks good to me. Same as your other PR, could you please comment in the corresponding issue ? It's a Github thing where a non-maintainer doesn't show up in the list of assignees until they comment there.

@vprusso
Copy link
Owner

vprusso commented Jul 15, 2024

Great work, @FabienGhd !

Thank you again for your contribution to toqito!

@vprusso vprusso merged commit 4d8ab7c into vprusso:master Jul 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename cyclic_permutation to cyclic_permutation_matrix
3 participants