Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added is_anti_hermitian.py #798

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Added is_anti_hermitian.py #798

merged 6 commits into from
Sep 25, 2024

Conversation

tnemoz
Copy link
Contributor

@tnemoz tnemoz commented Sep 21, 2024

Description

Adds the is_anti_hermitian function to matrix_props. Fixes #766.

Changes

Notable changes that this PR has either accomplished or will accomplish. Feel free to add more lines to the itemized list
below.

  • Adds the is_anti_hermitian function to matrix_props. The function internally uses is_hermitian to limit code duplication.

Checklist

Before marking your PR ready for review, make sure you checked the following locally. If this is your first PR, you might be notified of some workflow failures after a maintainer has approved the workflow jobs to be run on your PR.

Additional information is available in the documentation.

  • Use ruff for errors related to code style and formatting.
  • Verify all previous and newly added unit tests pass in pytest.
  • Check the documentation build does not lead to any failures. Sphinx build can be checked locally for any failures related to your PR
  • Use linkcheck to check for broken links in the documentation
  • Use doctest to verify the examples in the function docstrings work as expected.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.7%. Comparing base (f9378e2) to head (eb5fe23).
Report is 13 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #798   +/-   ##
======================================
  Coverage    97.7%   97.7%           
======================================
  Files         166     167    +1     
  Lines        3247    3251    +4     
  Branches      795     795           
======================================
+ Hits         3174    3178    +4     
  Misses         48      48           
  Partials       25      25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vprusso
Copy link
Owner

vprusso commented Sep 22, 2024

Nice to see you here again, @tnemoz !

Thank you for the great work on this PR. LGTM, but I'll check with @purva-thakre as well to see if there are any additional comments. Great work, and thank you again!

@purva-thakre
Copy link
Collaborator

Hi @tnemoz, can you please comment on the corresponding issue?

I can't assign it to you right now. It's a Github thing. :)

@tnemoz
Copy link
Contributor Author

tnemoz commented Sep 23, 2024

@purva-thakre done! What's the point however? It isn't possible to merge if I'm not the one assigned to the issue?
The question might be a bit silly, I'm not entirely sure I understand the point of assigning an issue to someone in general except to prevent the duplication of efforts

@purva-thakre
Copy link
Collaborator

purva-thakre commented Sep 24, 2024

What's the point however? It isn't possible to merge if I'm not the one assigned to the issue?

@tnemoz It's to make sure your efforts and name show up in the changelog and release notes.

We can merge a PR without assigning an issue to you but it might not be that obvious as to who fixed it in the milestone tracker.

No worries. This is not a silly question.

BTW if you would like to work on other issues that are assigned to me or @vprusso, feel free to ask us about the progress and request it to be assigned to you if we haven't worked on it in a while.

@tnemoz
Copy link
Contributor Author

tnemoz commented Sep 24, 2024

@tnemoz It's to make sure your efforts and name show up in the changelog and release notes.

In that case, if I wanted to do a PR to improve something in the code that isn't related to an issue, is it better if I create an issue beforehand?

BTW if you would like to work on other issues that are assigned to me or @vprusso, feel free to ask us about the progress and request it to be assigned to you if we haven't worked on it in a while.

My bad, sorry for that. I'll make sure to do it next time!

@purva-thakre
Copy link
Collaborator

In that case, if I wanted to do a PR to improve something in the code that isn't related to an issue, is it better if I create an issue beforehand?

@tnemoz Yes, it's better to discuss the proposed changes before you work on them.

My bad, sorry for that. I'll make sure to do it next time!

No worries. I haven't worked on toqito in the past couple of weeks but I know I still have many issues assigned to me.

Copy link
Owner

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR, @tnemoz !

@vprusso vprusso merged commit 680053f into vprusso:master Sep 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a check for an anti-hermitian in matrix_props
3 participants