Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed qiskit as a dependency and added seeds to randomness-related functions #842

Merged
merged 19 commits into from
Oct 11, 2024

Conversation

tnemoz
Copy link
Contributor

@tnemoz tnemoz commented Oct 7, 2024

Description

Fixes #818 and fixes #820.

Changes

Notable changes that this PR has either accomplished or will accomplish. Feel free to add more lines to the itemized list
below.

  • Qiskit is no longer listed as a dependency
  • All the randomness-related functions now have a seed parameter that allows reproducibility.

Checklist

Before marking your PR ready for review, make sure you checked the following locally. If this is your first PR, you might be notified of some workflow failures after a maintainer has approved the workflow jobs to be run on your PR.

Additional information is available in the documentation.

  • Use ruff for errors related to code style and formatting.
  • Verify all previous and newly added unit tests pass in pytest.
  • Check the documentation build does not lead to any failures. Sphinx build can be checked locally for any failures related to your PR
  • Use linkcheck to check for broken links in the documentation
  • Use doctest to verify the examples in the function docstrings work as expected.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.8%. Comparing base (14549b5) to head (81a1a78).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #842   +/-   ##
======================================
  Coverage    97.8%   97.8%           
======================================
  Files         168     168           
  Lines        3259    3267    +8     
  Branches      800     800           
======================================
+ Hits         3189    3197    +8     
  Misses         46      46           
  Partials       24      24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purva-thakre
Copy link
Collaborator

@tnemoz Whenever you make changes to the toml file, you have to make sure to update the poetry lock file as well.

  • Run poetry lock if you have made changes to the dependencies listed in the toml file.
  • Run poetry lock --no-update if you have not made any changes to the toml file but git gives you a conflict error.

Hope this makes sense!

@tnemoz tnemoz marked this pull request as ready for review October 9, 2024 21:29
@purva-thakre purva-thakre self-requested a review October 10, 2024 11:20
@purva-thakre purva-thakre mentioned this pull request Oct 11, 2024
6 tasks
Copy link
Collaborator

@purva-thakre purva-thakre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

toqito/rand/random_density_matrix.py Outdated Show resolved Hide resolved
toqito/rand/random_povm.py Outdated Show resolved Hide resolved
tnemoz and others added 3 commits October 11, 2024 16:14
Co-authored-by: Purva Thakre <66048318+purva-thakre@users.noreply.github.com>
Co-authored-by: Purva Thakre <66048318+purva-thakre@users.noreply.github.com>
@purva-thakre purva-thakre merged commit 68267f9 into vprusso:master Oct 11, 2024
1 of 17 checks passed
@tnemoz tnemoz deleted the seeds_and_remove_qiskit branch October 13, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add seeds to the randomness-related function Remove Qiskit as dependency
2 participants