Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing "pure_to_mixed" with "vector_to_density_matrix" and then renaming to "to_density_matrix" #853

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

Shivansh20128
Copy link
Contributor

@Shivansh20128 Shivansh20128 commented Oct 11, 2024

Description

Provide a brief description of the PR's purpose here. If your PR is supposed to fix an existing issue, use
a keyword to link your PR to the issue.

The following changes are made as a response to the issue #847

  1. Remove the pure_to_mixed function (along with the associated tests)
  2. Replace any usages of pure_to_mixed with vector_to_density_matrix.
  3. Rename vector_to_density_matrix to just to_density_matrix as the input does not necessarily need to be a vector .

#Resolves #847

Changes

Notable changes that this PR has either accomplished or will accomplish. Feel free to add more lines to the itemized list
below.

  • Change 1

Checklist

Before marking your PR ready for review, make sure you checked the following locally. If this is your first PR, you might be notified of some workflow failures after a maintainer has approved the workflow jobs to be run on your PR.

Additional information is available in the documentation.

  • Use ruff for errors related to code style and formatting.
  • Verify all previous and newly added unit tests pass in pytest.
  • Check the documentation build does not lead to any failures. Sphinx build can be checked locally for any failures related to your PR
  • Use linkcheck to check for broken links in the documentation
  • Use doctest to verify the examples in the function docstrings work as expected.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.8%. Comparing base (58bf855) to head (c92c661).
Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #853     +/-   ##
========================================
- Coverage    97.8%   97.8%   -0.1%     
========================================
  Files         168     167      -1     
  Lines        3259    3251      -8     
  Branches      717     715      -2     
========================================
- Hits         3189    3181      -8     
  Misses         46      46             
  Partials       24      24             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purva-thakre purva-thakre mentioned this pull request Oct 11, 2024
6 tasks
Copy link
Owner

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Perhaps we wait for @purva-thakre to give her review as well.

Nice work, @Shivansh20128 !

@vprusso vprusso merged commit 2f9602f into vprusso:master Oct 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pure_to_mixed in favor of vector_to_density_matrix
2 participants