From 28e0797bbf21dc0317803f5351d02f455e7bb373 Mon Sep 17 00:00:00 2001 From: bendera Date: Fri, 31 Jan 2025 18:42:07 +0100 Subject: [PATCH] Set inner input value instead of attribute The native `input` value property and the `value` attribute have different effects. The `value` attribute is the default value, while the property represents the actual value. --- src/vscode-textfield/vscode-textfield.test.ts | 2 +- src/vscode-textfield/vscode-textfield.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vscode-textfield/vscode-textfield.test.ts b/src/vscode-textfield/vscode-textfield.test.ts index 3b0f07d8..7f83e4f6 100644 --- a/src/vscode-textfield/vscode-textfield.test.ts +++ b/src/vscode-textfield/vscode-textfield.test.ts @@ -16,7 +16,7 @@ describe('vscode-textfield', () => { expect(el).shadowDom.to.equal( ` - + ` ); diff --git a/src/vscode-textfield/vscode-textfield.ts b/src/vscode-textfield/vscode-textfield.ts index 90571c5b..92241543 100644 --- a/src/vscode-textfield/vscode-textfield.ts +++ b/src/vscode-textfield/vscode-textfield.ts @@ -379,7 +379,7 @@ export class VscodeTextfield ?readonly=${this.readonly} ?required=${this.required} step=${ifDefined(this.step)} - value=${ifDefined(this.type !== 'file' ? this._value : undefined)} + .value=${this._value} @blur=${this._onBlur} @change=${this._onChange} @focus=${this._onFocus}