fixed conflict with min/max macro on windows #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at osgQt it does something very similar. Checking now and have come across the OSG doing it... so some PR must have added it in it's long and winding path. I would like to get to the bottom of the problem before merging a fix though in case there is wider lessons to be learned. I presume Qt or vulkan headers include <windows.h>. Which file(s) report errors when compiling? My reading of the change is that is only affects the build of the vsgQt itself. Will applications that use vsgQt under Windows also have to add NOMINMAX as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite sure where the conflict is taking place but this only happens in vsgQt. Looks like the general consensus is to just disable the macro completely via
NOMINMAX.