APPX-88 & APPX-89: Default value for WriteConnectionSecretToRef and write values in lowercase #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed by args as serviceName
martini-source
changed the title
mhutter
requested changes
Aug 9, 2023
| @@ -1,19 +1,20 @@ | |||
| apiVersion: exoscale.appcat.vshn.io/v1 | |||
| kind: ExoscaleKafka | |||
| kind: exoscalekafka | |||
There was a problem hiding this comment.
That looks wrong? Does it matter?
There was a problem hiding this comment.
Probably, I'll revert the whole lowercase thingy.
mhutter
reviewed
Aug 9, 2023
| @@ -127,7 +127,7 @@ func mapArgsToInput(args []string) []Input { | |||
| inputList = append(inputList, input) | |||
| input = Input{} | |||
| } else { | |||
| input.Value = arg | |||
| input.Value = NormalizeName(arg) | |||
There was a problem hiding this comment.
Actually now that I think about it, I'm not sure that this (and APPX-89) is correct. While it might b e true that Spec.Parameters.Maintenance.DayOfWeek must be lowercase, it might be that other fields must be mixed case, no?
For example, I think fields like imagePullPolicy MUST be Always, and always is invalid.
There was a problem hiding this comment.
True, some consistency would have been amazing, oh well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: