Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APPX-88 & APPX-89: Default value for WriteConnectionSecretToRef and write values in lowercase #13

Closed
wants to merge 6 commits into from
Closed

APPX-88 & APPX-89: Default value for WriteConnectionSecretToRef and write values in lowercase #13

wants to merge 6 commits into from

Commits on Aug 9, 2023

  1. Refactor: use --kind flag for serviceDiscovery use first argument pas… 

    …sed by args as serviceName
    @martini-source
    martini-source committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    73c1417 View commit details
    Browse the repository at this point in the history

  2. Remove empty line

    @martini-source
    martini-source committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    7b3eb84 View commit details
    Browse the repository at this point in the history

  3. Use IndeFunc and changed required arg len from 4 to 3

    @martini-source
    martini-source committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    bcdadd0 View commit details
    Browse the repository at this point in the history

  4. Add default value for Spec.writeConnectionSecretToRef.Name as service… 

    …Name+"-creds+"
    @martini-source
    martini-source committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    adf88db View commit details
    Browse the repository at this point in the history

  5. fix merge error

    @martini-source
    martini-source committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    c9553db View commit details
    Browse the repository at this point in the history

  6. Fix invalid defaults and set values to lowercase by default

    @martini-source
    martini-source committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    ea05624 View commit details
    Browse the repository at this point in the history