Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure WriteConnectionSecretToRef is set #14

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Ensure WriteConnectionSecretToRef is set #14

merged 1 commit into from
Aug 10, 2023

Conversation

martini-source
Copy link
Member

Resolves APPX-88
Changes:

  • Spec.WriteConnectionSecretToRef.Name gets default Value of ServiceName+"-creds", get overwritten if set manually
  • Adds test cases for above changes
  • Fixes invalid field values in defaults and tests

@mhutter mhutter changed the title Fix/secret ref Ensure WriteConnectionSecretToRef is set Aug 10, 2023
mhutter
mhutter requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@mhutter mhutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also contains APPX-89?

@mhutter
Copy link
Member

mhutter commented Aug 10, 2023

Ah, no, it does not. My bad

@mhutter mhutter self-requested a review August 10, 2023 08:17
@martini-source @mhutter
Ensure writeConnectionSecretToRef is always set
4643db3 
This commit will ensure that every resource's
`spec.writeConnectionSecretToRef.name` is set (to a default value of
`serviceName+"-creds"`).

Resolves: APPX-88
Signed-off-by: Manuel Hutter <manuel@hutter.io>
@mhutter mhutter merged commit 42359af into master Aug 10, 2023
1 check passed
@mhutter mhutter deleted the fix/SecretRef branch August 10, 2023 08:57
@mhutter mhutter added the enhancement New feature or request label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhutter mhutter mhutter approved these changes

@davidgubler davidgubler Awaiting requested review from davidgubler

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martini-source @mhutter