changed StockFundamentalsService.AdvancedFundamentals return type to …

…array - returns an array instead of single value - fixes #96
vslee · Feb 4, 2021 · 4be2db2 · 4be2db2
1 parent 545d0da
commit 4be2db2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/IEXSharp/Service/Cloud/CoreData/StockFundamentals/IStockFundamentalsService.cs b/IEXSharp/Service/Cloud/CoreData/StockFundamentals/IStockFundamentalsService.cs
@@ -17,7 +17,7 @@ public interface IStockFundamentalsService
  /// <param name="symbol"></param>
  /// <param name="period"></param>
  /// <returns></returns>
- Task<IEXResponse<AdvancedFundamentalsResponse>> AdvancedFundamentalsAsync(string symbol, Period period = Period.Quarter);
+ Task<IEXResponse<IEnumerable<AdvancedFundamentalsResponse>>> AdvancedFundamentalsAsync(string symbol, Period period = Period.Quarter);
 
  /// <summary>
  /// <see cref="https://iexcloud.io/docs/api/#balance-sheet"/>

diff --git a/IEXSharp/Service/Cloud/CoreData/StockFundamentals/StockFundamentalsService.cs b/IEXSharp/Service/Cloud/CoreData/StockFundamentals/StockFundamentalsService.cs
@@ -18,7 +18,7 @@ internal StockFundamentalsService(ExecutorREST executor)
  this.executor = executor;
  }
 
- public async Task<IEXResponse<AdvancedFundamentalsResponse>> AdvancedFundamentalsAsync(string symbol, Period period = Period.Quarter)
+ public async Task<IEXResponse<IEnumerable<AdvancedFundamentalsResponse>>> AdvancedFundamentalsAsync(string symbol, Period period = Period.Quarter)
  {
  const string urlPattern = "time-series/fundamentals/[symbol]/[period]";
 
@@ -30,7 +30,7 @@ public async Task<IEXResponse<AdvancedFundamentalsResponse>> AdvancedFundamental
  {"period", period.GetDescriptionFromEnum()}
  };
 
- return await executor.ExecuteAsync<AdvancedFundamentalsResponse>(urlPattern, pathNvc, qsb);
+ return await executor.ExecuteAsync<IEnumerable<AdvancedFundamentalsResponse>>(urlPattern, pathNvc, qsb);
  }
 
  public async Task<IEXResponse<BalanceSheetResponse>> BalanceSheetAsync(string symbol, Period period = Period.Quarter,

diff --git a/IEXSharpTest/Cloud/CoreData/StockFundamentalsTest.cs b/IEXSharpTest/Cloud/CoreData/StockFundamentalsTest.cs
@@ -26,6 +26,7 @@ public void Setup()
  [Test]
  [TestCase("BEDU", Period.Annual)]
  [TestCase("BEDU", Period.Quarter)]
+ [TestCase("F", Period.Annual)]
  [TestCase("CCM", Period.Quarter)]
  [TestCase("AAPL", Period.Quarter)]
  [TestCase("FB", Period.Quarter)]
@@ -34,8 +35,11 @@ public async Task AdvancedFundamentalsAsyncTest(string symbol, Period period = P
  var response = await sandBoxClient.StockFundamentals.AdvancedFundamentalsAsync(symbol, period);
 
  Assert.IsNull(response.ErrorMessage);
- Assert.IsNotNull(response.Data);
- Assert.IsNotNull(response.Data.accountsPayable);
+ foreach (var data in response.Data)
+ {
+ Assert.IsNotNull(data);
+ Assert.IsNotNull(data.accountsPayable);
+ }
  }