From ee3bf45e5e253d393f8553e58715c31e470800cd Mon Sep 17 00:00:00 2001
From: Alex Waygood <Alex.Waygood@Gmail.com>
Date: Sun, 6 Aug 2023 20:40:55 +0100
Subject: [PATCH] gh-106368: Improve coverage reports for argument clinic
 (#107693)

---
 .coveragerc            |  5 +++++
 Tools/clinic/clinic.py | 11 +++++++----
 Tools/clinic/cpp.py    | 10 ++++++++--
 3 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/.coveragerc b/.coveragerc
index 18bf2f40fe523f..b5d94317e8aa8b 100644
--- a/.coveragerc
+++ b/.coveragerc
@@ -7,6 +7,11 @@ exclude_lines =
     # Don't complain if non-runnable code isn't run:
     if 0:
     if __name__ == .__main__.:
+    raise AssertionError\(
+
+    # Empty bodies in protocols or abstract methods
+    ^\s*def [a-zA-Z0-9_]+\(.*\)(\s*->.*)?:\s*\.\.\.(\s*#.*)?$
+    ^\s*\.\.\.(\s*#.*)?$
 
     .*# pragma: no cover
     .*# pragma: no branch
diff --git a/Tools/clinic/clinic.py b/Tools/clinic/clinic.py
index 423cdfb939c161..47b5f5ae32f581 100755
--- a/Tools/clinic/clinic.py
+++ b/Tools/clinic/clinic.py
@@ -469,7 +469,7 @@ class Language(metaclass=abc.ABCMeta):
     checksum_line = ""
 
     def __init__(self, filename: str) -> None:
-        pass
+        ...
 
     @abc.abstractmethod
     def render(
@@ -477,10 +477,10 @@ def render(
             clinic: Clinic | None,
             signatures: Iterable[Module | Class | Function]
     ) -> str:
-        pass
+        ...
 
     def parse_line(self, line: str) -> None:
-        pass
+        ...
 
     def validate(self) -> None:
         def assert_only_one(
@@ -2862,6 +2862,9 @@ def __getattr__(self, attr):
                     f"Note: accessing self.function inside converter_init is disallowed!"
                 )
             return super().__getattr__(attr)
+    # this branch is just here for coverage reporting
+    else:  # pragma: no cover
+        pass
 
     def converter_init(self) -> None:
         pass
@@ -3990,7 +3993,7 @@ def correct_name_for_self(
         return "void *", "null"
     if f.kind in (CLASS_METHOD, METHOD_NEW):
         return "PyTypeObject *", "type"
-    raise RuntimeError("Unhandled type of function f: " + repr(f.kind))
+    raise AssertionError(f"Unhandled type of function f: {f.kind!r}")
 
 def required_type_for_self_for_parser(
         f: Function
diff --git a/Tools/clinic/cpp.py b/Tools/clinic/cpp.py
index 876105120c97f2..3d9c61ac678965 100644
--- a/Tools/clinic/cpp.py
+++ b/Tools/clinic/cpp.py
@@ -178,11 +178,17 @@ def pop_stack() -> TokenAndCondition:
         if self.verbose:
             print(self.status())
 
-if __name__ == '__main__':
-    for filename in sys.argv[1:]:
+
+def _main(filenames: list[str] | None = None) -> None:
+    filenames = filenames or sys.argv[1:]
+    for filename in filenames:
         with open(filename) as f:
             cpp = Monitor(filename, verbose=True)
             print()
             print(filename)
             for line_number, line in enumerate(f.read().split('\n'), 1):
                 cpp.writeline(line)
+
+
+if __name__ == '__main__':
+    _main()