From 3183cd5d10cebd669c1f440ae4116eadd4c1c2ac Mon Sep 17 00:00:00 2001 From: Thorsten Date: Wed, 11 Oct 2017 23:40:33 +0200 Subject: [PATCH 01/12] Finished testable version. --- template/build/dev-client.js | 10 --- template/build/dev-server.js | 107 ----------------------------- template/build/logo.png | Bin 0 -> 6849 bytes template/build/utils.js | 21 ++++++ template/build/webpack.dev.conf.js | 51 ++++++++++++-- template/config/index.js | 50 ++++++++++---- template/package.json | 10 +-- template/test/e2e/runner.js | 25 +++++-- 8 files changed, 125 insertions(+), 149 deletions(-) delete mode 100644 template/build/dev-client.js delete mode 100644 template/build/dev-server.js create mode 100644 template/build/logo.png diff --git a/template/build/dev-client.js b/template/build/dev-client.js deleted file mode 100644 index 2f75dd531f..0000000000 --- a/template/build/dev-client.js +++ /dev/null @@ -1,10 +0,0 @@ -/* eslint-disable */ -'use strict' -require('eventsource-polyfill') -var hotClient = require('webpack-hot-middleware/client?noInfo=true&reload=true') - -hotClient.subscribe(function (event) { - if (event.action === 'reload') { - window.location.reload() - } -}) diff --git a/template/build/dev-server.js b/template/build/dev-server.js deleted file mode 100644 index 00d9efd144..0000000000 --- a/template/build/dev-server.js +++ /dev/null @@ -1,107 +0,0 @@ -'use strict' -require('./check-versions')() - -const config = require('../config') -if (!process.env.NODE_ENV) { - process.env.NODE_ENV = JSON.parse(config.dev.env.NODE_ENV) -} - -const opn = require('opn') -const path = require('path') -const express = require('express') -const webpack = require('webpack') -const proxyMiddleware = require('http-proxy-middleware') -const webpackConfig = {{#if_or unit e2e}}(process.env.NODE_ENV === 'testing' || process.env.NODE_ENV === 'production') - ? require('./webpack.prod.conf') - : {{/if_or}}require('./webpack.dev.conf') - -// default port where dev server listens for incoming traffic -const port = process.env.PORT || config.dev.port -// automatically open browser, if not set will be false -const autoOpenBrowser = !!config.dev.autoOpenBrowser -// Define HTTP proxies to your custom API backend -// https://github.com/chimurai/http-proxy-middleware -const proxyTable = config.dev.proxyTable - -const app = express() -const compiler = webpack(webpackConfig) - -const devMiddleware = require('webpack-dev-middleware')(compiler, { - publicPath: webpackConfig.output.publicPath, - quiet: true -}) - -const hotMiddleware = require('webpack-hot-middleware')(compiler, { - log: false, - heartbeat: 2000 -}) -// force page reload when html-webpack-plugin template changes -// currently disabled until this is resolved: -// https://github.com/jantimon/html-webpack-plugin/issues/680 -// compiler.plugin('compilation', function (compilation) { -// compilation.plugin('html-webpack-plugin-after-emit', function (data, cb) { -// hotMiddleware.publish({ action: 'reload' }) -// cb() -// }) -// }) - -// enable hot-reload and state-preserving -// compilation error display -app.use(hotMiddleware) - -// proxy api requests -Object.keys(proxyTable).forEach(function (context) { - let options = proxyTable[context] - if (typeof options === 'string') { - options = { target: options } - } - app.use(proxyMiddleware(options.filter || context, options)) -}) - -// handle fallback for HTML5 history API -app.use(require('connect-history-api-fallback')()) - -// serve webpack bundle output -app.use(devMiddleware) - -// serve pure static assets -const staticPath = path.posix.join(config.dev.assetsPublicPath, config.dev.assetsSubDirectory) -app.use(staticPath, express.static('./static')) - -const uri = 'http://localhost:' + port - -var _resolve -var _reject -var readyPromise = new Promise((resolve, reject) => { - _resolve = resolve - _reject = reject -}) - -var server -var portfinder = require('portfinder') -portfinder.basePort = port - -console.log('> Starting dev server...') -devMiddleware.waitUntilValid(() => { - portfinder.getPort((err, port) => { - if (err) { - _reject(err) - } - process.env.PORT = port - var uri = 'http://localhost:' + port - console.log('> Listening at ' + uri + '\n') - // when env is testing, don't need open it - if (autoOpenBrowser && process.env.NODE_ENV !== 'testing') { - opn(uri) - } - server = app.listen(port) - _resolve() - }) -}) - -module.exports = { - ready: readyPromise, - close: () => { - server.close() - } -} diff --git a/template/build/logo.png b/template/build/logo.png new file mode 100644 index 0000000000000000000000000000000000000000..f3d2503fc2a44b5053b0837ebea6e87a2d339a43 GIT binary patch literal 6849 zcmaKRcUV(fvo}bjDT-7nLI_nlK}sT_69H+`qzVWDA|yaU?}j417wLi^B1KB1SLsC& zL0ag7$U(XW5YR7p&Ux?sP$d4lvMt8C^+TcQu4F zQqv!UF!I+kw)c0jhd6+g6oCr9P?7)?!qX1ui*iL{p}sKCAGuJ{{W)0z1pLF|=>h}& zt(2Lr0Z`2ig8<5i%Zk}cO5Fm=LByqGWaS`oqChZdEFmc`0hSb#gg|Aap^{+WKOYcj zHjINK)KDG%&s?Mt4CL(T=?;~U@bU2x_mLKN!#GJuK_CzbNw5SMEJorG!}_5;?R>@1 zSl)jns3WlU7^J%=(hUtfmuUCU&C3%8B5C^f5>W2Cy8jW3#{Od{lF1}|?c61##3dzA zsPlFG;l_FzBK}8>|H_Ru_H#!_7$UH4UKo3lKOA}g1(R&|e@}GINYVzX?q=_WLZCgh z)L|eJMce`D0EIwgRaNETDsr+?vQknSGAi=7H00r`QnI%oQnFxm`G2umXso9l+8*&Q z7WqF|$p49js$mdzo^BXpH#gURy=UO;=IMrYc5?@+sR4y_?d*~0^YP7d+y0{}0)zBM zIKVM(DBvICK#~7N0a+PY6)7;u=dutmNqK3AlsrUU9U`d;msiucB_|8|2kY=(7XA;G zwDA8AR)VCA#JOkxm#6oHNS^YVuOU;8p$N)2{`;oF|rQ?B~K$%rHDxXs+_G zF5|-uqHZvSzq}L;5Kcy_P+x0${33}Ofb6+TX&=y;;PkEOpz%+_bCw_{<&~ zeLV|!bP%l1qxywfVr9Z9JI+++EO^x>ZuCK);=$VIG1`kxK8F2M8AdC$iOe3cj1fo(ce4l-9 z7*zKy3={MixvUk=enQE;ED~7tv%qh&3lR<0m??@w{ILF|e#QOyPkFYK!&Up7xWNtL zOW%1QMC<3o;G9_S1;NkPB6bqbCOjeztEc6TsBM<(q9((JKiH{01+Ud=uw9B@{;(JJ z-DxI2*{pMq`q1RQc;V8@gYAY44Z!%#W~M9pRxI(R?SJ7sy7em=Z5DbuDlr@*q|25V)($-f}9c#?D%dU^RS<(wz?{P zFFHtCab*!rl(~j@0(Nadvwg8q|4!}L^>d?0al6}Rrv9$0M#^&@zjbfJy_n!%mVHK4 z6pLRIQ^Uq~dnyy$`ay51Us6WaP%&O;@49m&{G3z7xV3dLtt1VTOMYl3UW~Rm{Eq4m zF?Zl_v;?7EFx1_+#WFUXxcK78IV)FO>42@cm@}2I%pVbZqQ}3;p;sDIm&knay03a^ zn$5}Q$G!@fTwD$e(x-~aWP0h+4NRz$KlnO_H2c< z(XX#lPuW_%H#Q+c&(nRyX1-IadKR-%$4FYC0fsCmL9ky3 zKpxyjd^JFR+vg2!=HWf}2Z?@Td`0EG`kU?{8zKrvtsm)|7>pPk9nu@2^z96aU2<#` z2QhvH5w&V;wER?mopu+nqu*n8p~(%QkwSs&*0eJwa zMXR05`OSFpfyRb!Y_+H@O%Y z0=K^y6B8Gcbl?SA)qMP3Z+=C(?8zL@=74R=EVnE?vY!1BQy2@q*RUgRx4yJ$k}MnL zs!?74QciNb-LcG*&o<9=DSL>1n}ZNd)w1z3-0Pd^4ED1{qd=9|!!N?xnXjM!EuylY z5=!H>&hSofh8V?Jofyd!h`xDI1fYAuV(sZwwN~{$a}MX^=+0TH*SFp$vyxmUv7C*W zv^3Gl0+eTFgBi3FVD;$nhcp)ka*4gSskYIqQ&+M}xP9yLAkWzBI^I%zR^l1e?bW_6 zIn{mo{dD=)9@V?s^fa55jh78rP*Ze<3`tRCN4*mpO$@7a^*2B*7N_|A(Ve2VB|)_o z$=#_=aBkhe(ifX}MLT()@5?OV+~7cXC3r!%{QJxriXo9I%*3q4KT4Xxzyd{ z9;_%=W%q!Vw$Z7F3lUnY+1HZ*lO;4;VR2+i4+D(m#01OYq|L_fbnT;KN<^dkkCwtd zF7n+O7KvAw8c`JUh6LmeIrk4`F3o|AagKSMK3))_5Cv~y2Bb2!Ibg9BO7Vkz?pAYX zoI=B}+$R22&IL`NCYUYjrdhwjnMx_v=-Qcx-jmtN>!Zqf|n1^SWrHy zK|MwJ?Z#^>)rfT5YSY{qjZ&`Fjd;^vv&gF-Yj6$9-Dy$<6zeP4s+78gS2|t%Z309b z0^fp~ue_}i`U9j!<|qF92_3oB09NqgAoehQ`)<)dSfKoJl_A6Ec#*Mx9Cpd-p#$Ez z={AM*r-bQs6*z$!*VA4|QE7bf@-4vb?Q+pPKLkY2{yKsw{&udv_2v8{Dbd zm~8VAv!G~s)`O3|Q6vFUV%8%+?ZSVUa(;fhPNg#vab@J*9XE4#D%)$UU-T5`fwjz! z6&gA^`OGu6aUk{l*h9eB?opVdrHK>Q@U>&JQ_2pR%}TyOXGq_6s56_`U(WoOaAb+K zXQr#6H}>a-GYs9^bGP2Y&hSP5gEtW+GVC4=wy0wQk=~%CSXj=GH6q z-T#s!BV`xZVxm{~jr_ezYRpqqIcXC=Oq`b{lu`Rt(IYr4B91hhVC?yg{ol4WUr3v9 zOAk2LG>CIECZ-WIs0$N}F#eoIUEtZudc7DPYIjzGqDLWk_A4#(LgacooD z2K4IWs@N`Bddm-{%oy}!k0^i6Yh)uJ1S*90>|bm3TOZxcV|ywHUb(+CeX-o1|LTZM zwU>dY3R&U)T(}5#Neh?-CWT~@{6Ke@sI)uSuzoah8COy)w)B)aslJmp`WUcjdia-0 zl2Y}&L~XfA`uYQboAJ1;J{XLhYjH){cObH3FDva+^8ioOQy%Z=xyjGLmWMrzfFoH; zEi3AG`_v+%)&lDJE;iJWJDI@-X9K5O)LD~j*PBe(wu+|%ar~C+LK1+-+lK=t# z+Xc+J7qp~5q=B~rD!x78)?1+KUIbYr^5rcl&tB-cTtj+e%{gpZZ4G~6r15+d|J(ky zjg@@UzMW0k9@S#W(1H{u;Nq(7llJbq;;4t$awM;l&(2s+$l!Ay9^Ge|34CVhr7|BG z?dAR83smef^frq9V(OH+a+ki#q&-7TkWfFM=5bsGbU(8mC;>QTCWL5ydz9s6k@?+V zcjiH`VI=59P-(-DWXZ~5DH>B^_H~;4$)KUhnmGo*G!Tq8^LjfUDO)lASN*=#AY_yS zqW9UX(VOCO&p@kHdUUgsBO0KhXxn1sprK5h8}+>IhX(nSXZKwlNsjk^M|RAaqmCZB zHBolOHYBas@&{PT=R+?d8pZu zUHfyucQ`(umXSW7o?HQ3H21M`ZJal+%*)SH1B1j6rxTlG3hx1IGJN^M7{$j(9V;MZ zRKybgVuxKo#XVM+?*yTy{W+XHaU5Jbt-UG33x{u(N-2wmw;zzPH&4DE103HV@ER86 z|FZEmQb|&1s5#`$4!Cm}&`^{(4V}OP$bk`}v6q6rm;P!H)W|2i^e{7lTk2W@jo_9q z*aw|U7#+g59Fv(5qI`#O-qPj#@_P>PC#I(GSp3DLv7x-dmYK=C7lPF8a)bxb=@)B1 zUZ`EqpXV2dR}B&r`uM}N(TS99ZT0UB%IN|0H%DcVO#T%L_chrgn#m6%x4KE*IMfjX zJ%4veCEqbXZ`H`F_+fELMC@wuy_ch%t*+Z+1I}wN#C+dRrf2X{1C8=yZ_%Pt6wL_~ zZ2NN-hXOT4P4n$QFO7yYHS-4wF1Xfr-meG9Pn;uK51?hfel`d38k{W)F*|gJLT2#T z<~>spMu4(mul-8Q3*pf=N4DcI)zzjqAgbE2eOT7~&f1W3VsdD44Ffe;3mJp-V@8UC z)|qnPc12o~$X-+U@L_lWqv-RtvB~%hLF($%Ew5w>^NR82qC_0FB z)=hP1-OEx?lLi#jnLzH}a;Nvr@JDO-zQWd}#k^an$Kwml;MrD&)sC5b`s0ZkVyPkb zt}-jOq^%_9>YZe7Y}PhW{a)c39G`kg(P4@kxjcYfgB4XOOcmezdUI7j-!gs7oAo2o zx(Ph{G+YZ`a%~kzK!HTAA5NXE-7vOFRr5oqY$rH>WI6SFvWmahFav!CfRMM3%8J&c z*p+%|-fNS_@QrFr(at!JY9jCg9F-%5{nb5Bo~z@Y9m&SHYV`49GAJjA5h~h4(G!Se zZmK{Bo7ivCfvl}@A-ptkFGcWXAzj3xfl{evi-OG(TaCn1FAHxRc{}B|x+Ua1D=I6M z!C^ZIvK6aS_c&(=OQDZfm>O`Nxsw{ta&yiYPA~@e#c%N>>#rq)k6Aru-qD4(D^v)y z*>Rs;YUbD1S8^D(ps6Jbj0K3wJw>L4m)0e(6Pee3Y?gy9i0^bZO?$*sv+xKV?WBlh zAp*;v6w!a8;A7sLB*g-^<$Z4L7|5jXxxP1}hQZ<55f9<^KJ>^mKlWSGaLcO0=$jem zWyZkRwe~u{{tU63DlCaS9$Y4CP4f?+wwa(&1ou)b>72ydrFvm`Rj-0`kBJgK@nd(*Eh!(NC{F-@=FnF&Y!q`7){YsLLHf0_B6aHc# z>WIuHTyJwIH{BJ4)2RtEauC7Yq7Cytc|S)4^*t8Va3HR zg=~sN^tp9re@w=GTx$;zOWMjcg-7X3Wk^N$n;&Kf1RgVG2}2L-(0o)54C509C&77i zrjSi{X*WV=%C17((N^6R4Ya*4#6s_L99RtQ>m(%#nQ#wrRC8Y%yxkH;d!MdY+Tw@r zjpSnK`;C-U{ATcgaxoEpP0Gf+tx);buOMlK=01D|J+ROu37qc*rD(w`#O=3*O*w9?biwNoq3WN1`&Wp8TvKj3C z3HR9ssH7a&Vr<6waJrU zdLg!ieYz%U^bmpn%;(V%%ugMk92&?_XX1K@mwnVSE6!&%P%Wdi7_h`CpScvspMx?N zQUR>oadnG17#hNc$pkTp+9lW+MBKHRZ~74XWUryd)4yd zj98$%XmIL4(9OnoeO5Fnyn&fpQ9b0h4e6EHHw*l68j;>(ya`g^S&y2{O8U>1*>4zR zq*WSI_2o$CHQ?x0!wl9bpx|Cm2+kFMR)oMud1%n2=qn5nE&t@Fgr#=Zv2?}wtEz^T z9rrj=?IH*qI5{G@Rn&}^Z{+TW}mQeb9=8b<_a`&Cm#n%n~ zU47MvCBsdXFB1+adOO)03+nczfWa#vwk#r{o{dF)QWya9v2nv43Zp3%Ps}($lA02*_g25t;|T{A5snSY?3A zrRQ~(Ygh_ebltHo1VCbJb*eOAr;4cnlXLvI>*$-#AVsGg6B1r7@;g^L zFlJ_th0vxO7;-opU@WAFe;<}?!2q?RBrFK5U{*ai@NLKZ^};Ul}beukveh?TQn;$%9=R+DX07m82gP$=}Uo_%&ngV`}Hyv8g{u z3SWzTGV|cwQuFIs7ZDOqO_fGf8Q`8MwL}eUp>q?4eqCmOTcwQuXtQckPy|4F1on8l zP*h>d+cH#XQf|+6c|S{7SF(Lg>bR~l(0uY?O{OEVlaxa5@e%T&xju=o1`=OD#qc16 zSvyH*my(dcp6~VqR;o(#@m44Lug@~_qw+HA=mS#Z^4reBy8iV?H~I;{LQWk3aKK8$bLRyt$g?- { + if (severity !== 'error') { + return + } + console.log('it should notify!!') + const error = errors[0] + + const filename = error.file.split('!').pop() + notifier.notify({ + title: pkg.name, + message: severity + ': ' + error.name, + subtitle: filename || '', + icon: path.join(__dirname, 'logo.png') + }) + } +} diff --git a/template/build/webpack.dev.conf.js b/template/build/webpack.dev.conf.js index 6f25d63458..3c494b01ec 100644 --- a/template/build/webpack.dev.conf.js +++ b/template/build/webpack.dev.conf.js @@ -6,18 +6,31 @@ const merge = require('webpack-merge') const baseWebpackConfig = require('./webpack.base.conf') const HtmlWebpackPlugin = require('html-webpack-plugin') const FriendlyErrorsPlugin = require('friendly-errors-webpack-plugin') +const portfinder = require('portfinder') -// add hot-reload related code to entry chunks -Object.keys(baseWebpackConfig.entry).forEach(function (name) { - baseWebpackConfig.entry[name] = ['./build/dev-client'].concat(baseWebpackConfig.entry[name]) -}) - -module.exports = merge(baseWebpackConfig, { +const devWebpackConfig = merge(baseWebpackConfig, { module: { rules: utils.styleLoaders({ sourceMap: config.dev.cssSourceMap }) }, // cheap-module-eval-source-map is faster for development devtool: '#cheap-module-eval-source-map', + + // these devServer options should be customized in /config/index.js + devServer: { + host: process.env.HOST || config.dev.host, + port: process.env.PORT || config.dev.port, + open: config.dev.autoOpenBrowser, + overlay: config.dev.errorOverlay ? { + warnings: true, + errors: true, + } : false, + publicPath: config.dev.assetsPublicPath, + proxy: config.dev.proxyTable, + quiet: true, // necessary for FriendlyErrorsPlugin + watchOptions: { + poll: config.dev.poll, + } + }, plugins: [ new webpack.DefinePlugin({ 'process.env': config.dev.env @@ -34,3 +47,29 @@ module.exports = merge(baseWebpackConfig, { new FriendlyErrorsPlugin() ] }) + +module.exports = new Promise((resolve, reject) => { + portfinder.basePort = process.env.PORT || config.dev.port + portfinder.getPort((err, port) => { + if (err) { + reject(err) + } else { + // publish the new Port, necessary for e2e tests + process.env.PORT = port + // add port to devServer config + devWebpackConfig.devServer.port = port + + // Add FriendlyErrorsPlugin + devWebpackConfig.plugins.push(new FriendlyErrorsPlugin({ + compilationSuccessInfo: { + messages: [`You application is running here http://${config.dev.host}:${port}`], + }, + onErrors: config.dev.notifyOnErrors + ? utils.createNotifierCallback() + : undefined + })) + + resolve(devWebpackConfig) + } + }) +}) diff --git a/template/config/index.js b/template/config/index.js index 0bc0b6a7a6..1250e7e97b 100644 --- a/template/config/index.js +++ b/template/config/index.js @@ -5,37 +5,59 @@ const path = require('path') module.exports = { + dev: { + env: require('./dev.env'), + host: 'localhost', // can be overwritten by process.env.HOST + port: 8080, // can be overwritten by process.env.HOST, if port is in use, a free one will be determined + + // Paths + assetsSubDirectory: 'static', + assetsPublicPath: '/', + proxyTable: {}, + + // Various Dev Server settings + autoOpenBrowser: false, + errorOverlay: true, + notifyOnErrors: true, + poll: false, // https://webpack.js.org/configuration/dev-server/#devserver-watchoptions- + + // Use Eslint Loader? + // If true, your code will be linted during bundling and + // linting errors and warings will be shown in the console. + useEslint: true, + // If true, eslint errors and warings will also be shown in the error overlay + // in the browser. + showEslintErrorsInOverlay: false, + + // CSS Sourcemaps off by default because relative paths are "buggy" + // with this option, according to the CSS-Loader README + // (https://github.com/webpack/css-loader#sourcemaps) + // In our experience, they generally work as expected, + // just be aware of this issue when enabling this option. + cssSourceMap: false + }, build: { env: require('./prod.env'), index: path.resolve(__dirname, '../dist/index.html'), + + // Paths assetsRoot: path.resolve(__dirname, '../dist'), assetsSubDirectory: 'static', assetsPublicPath: '/', + productionSourceMap: true, // Gzip off by default as many popular static hosts such as // Surge or Netlify already gzip all static assets for you. // Before setting to `true`, make sure to: // npm install --save-dev compression-webpack-plugin + productionGzip: false, productionGzipExtensions: ['js', 'css'], // Run the build command with an extra argument to // View the bundle analyzer report after build finishes: // `npm run build --report` // Set to `true` or `false` to always turn it on or off + bundleAnalyzerReport: process.env.npm_config_report - }, - dev: { - env: require('./dev.env'), - port: process.env.PORT || 8080, - autoOpenBrowser: true, - assetsSubDirectory: 'static', - assetsPublicPath: '/', - proxyTable: {}, - // CSS Sourcemaps off by default because relative paths are "buggy" - // with this option, according to the CSS-Loader README - // (https://github.com/webpack/css-loader#sourcemaps) - // In our experience, they generally work as expected, - // just be aware of this issue when enabling this option. - cssSourceMap: false } } diff --git a/template/package.json b/template/package.json index 86921c4fa4..6b8b82765c 100644 --- a/template/package.json +++ b/template/package.json @@ -5,7 +5,7 @@ "author": "{{ author }}", "private": true, "scripts": { - "dev": "node build/dev-server.js", + "dev": "webpack-dev-server --inline --hot --progress --config build/webpack.dev.conf.js", "start": "npm run dev", "build": "node build/build.js"{{#unit}}, "unit": "cross-env BABEL_ENV=test karma start test/unit/karma.conf.js --single-run"{{/unit}}{{#e2e}}, @@ -29,7 +29,6 @@ "babel-preset-stage-2": "^6.22.0", "babel-register": "^6.22.0", "chalk": "^2.0.1", - "connect-history-api-fallback": "^1.3.0", "copy-webpack-plugin": "^4.0.1", "css-loader": "^0.28.0", {{#lint}} @@ -51,12 +50,10 @@ {{/if_eq}} {{/lint}} "eventsource-polyfill": "^0.9.6", - "express": "^4.14.1", "extract-text-webpack-plugin": "^3.0.0", "file-loader": "^1.1.4", "friendly-errors-webpack-plugin": "^1.6.1", "html-webpack-plugin": "^2.30.1", - "http-proxy-middleware": "^0.17.3", "webpack-bundle-analyzer": "^2.9.0", {{#unit}} "cross-env": "^5.0.1", @@ -70,6 +67,7 @@ "karma-spec-reporter": "0.0.31", "karma-webpack": "^2.0.2", "mocha": "^3.2.0", + "node-notifier": "5.1.2", "chai": "^4.1.2", "sinon": "^4.0.0", "sinon-chai": "^2.8.0", @@ -85,7 +83,6 @@ {{/e2e}} "semver": "^5.3.0", "shelljs": "^0.7.6", - "opn": "^5.1.0", "optimize-css-assets-webpack-plugin": "^3.2.0", "ora": "^1.2.0", "rimraf": "^2.6.0", @@ -95,8 +92,7 @@ "vue-template-compiler": "^2.4.2", "portfinder": "^1.0.13", "webpack": "^3.6.0", - "webpack-dev-middleware": "^1.12.0", - "webpack-hot-middleware": "^2.18.2", + "webpack-dev-server": "^2.9.1", "webpack-merge": "^4.1.0" }, "engines": { diff --git a/template/test/e2e/runner.js b/template/test/e2e/runner.js index 6b30c61e17..de22bfda22 100644 --- a/template/test/e2e/runner.js +++ b/template/test/e2e/runner.js @@ -1,8 +1,23 @@ // 1. start the dev server using production config process.env.NODE_ENV = 'testing'{{#if_eq lintConfig "airbnb"}};{{/if_eq}} -var server = require('../../build/dev-server.js'){{#if_eq lintConfig "airbnb"}};{{/if_eq}} -server.ready.then(() => { +const webpack = require('webpack'){{#if_eq lintConfig "airbnb"}};{{/if_eq}} +const DevServer = require('webpack-dev-server'){{#if_eq lintConfig "airbnb"}};{{/if_eq}} + +const webpackConfig = require('../../build/webpack.prod.conf'){{#if_eq lintConfig "airbnb"}};{{/if_eq}} +const devConfigPromise = require('../../build/webpack.dev.conf'){{#if_eq lintConfig "airbnb"}};{{/if_eq}} + +let server{{#if_eq lintConfig "airbnb"}};{{/if_eq}} + +devConfigPromise.then(devConfig => { + const devServerOptions = devConfig.devServer{{#if_eq lintConfig "airbnb"}};{{/if_eq}} + const compiler = webpack(webpackConfig){{#if_eq lintConfig "airbnb"}};{{/if_eq}} + server = new DevServer(compiler, devServerOptions){{#if_eq lintConfig "airbnb"}};{{/if_eq}} + const port = devServerOptions.port{{#if_eq lintConfig "airbnb"}};{{/if_eq}} + const host = devServerOptions.host{{#if_eq lintConfig "airbnb"}};{{/if_eq}} + return server.listen(port, host){{#if_eq lintConfig "airbnb"}};{{/if_eq}} +}) +.then(() => { // 2. run the nightwatch test suite against it // to run in additional browsers: // 1. add an entry in test/e2e/nightwatch.conf.json under "test_settings" @@ -10,7 +25,7 @@ server.ready.then(() => { // or override the environment flag, for example: `npm run e2e -- --env chrome,firefox` // For more information on Nightwatch's config file, see // http://nightwatchjs.org/guide#settings-file - var opts = process.argv.slice(2){{#if_eq lintConfig "airbnb"}};{{/if_eq}} + let opts = process.argv.slice(2){{#if_eq lintConfig "airbnb"}};{{/if_eq}} if (opts.indexOf('--config') === -1) { opts = opts.concat(['--config', 'test/e2e/nightwatch.conf.js']){{#if_eq lintConfig "airbnb"}};{{/if_eq}} } @@ -18,8 +33,8 @@ server.ready.then(() => { opts = opts.concat(['--env', 'chrome']){{#if_eq lintConfig "airbnb"}};{{/if_eq}} } - var spawn = require('cross-spawn'){{#if_eq lintConfig "airbnb"}};{{/if_eq}} - var runner = spawn('./node_modules/.bin/nightwatch', opts, { stdio: 'inherit' }){{#if_eq lintConfig "airbnb"}};{{/if_eq}} + const spawn = require('cross-spawn'){{#if_eq lintConfig "airbnb"}};{{/if_eq}} + const runner = spawn('./node_modules/.bin/nightwatch', opts, { stdio: 'inherit' }){{#if_eq lintConfig "airbnb"}};{{/if_eq}} runner.on('exit', function (code) { server.close(){{#if_eq lintConfig "airbnb"}};{{/if_eq}} From 7a6c554f2dce2bfdac416a11176d6837dde9ec61 Mon Sep 17 00:00:00 2001 From: Thorsten Date: Wed, 11 Oct 2017 23:42:43 +0200 Subject: [PATCH 02/12] close #960 --- template/build/webpack.base.conf.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/template/build/webpack.base.conf.js b/template/build/webpack.base.conf.js index f0f56c5115..e6985eef6d 100644 --- a/template/build/webpack.base.conf.js +++ b/template/build/webpack.base.conf.js @@ -31,15 +31,16 @@ module.exports = { module: { rules: [ {{#lint}} - { + ...(config.dev.useEslint? [{ test: /\.(js|vue)$/, loader: 'eslint-loader', enforce: 'pre', include: [resolve('src'), resolve('test')], options: { - formatter: require('eslint-friendly-formatter') + formatter: require('eslint-friendly-formatter'), + emitWaring: !config.dev.showEslintErrorsInOverlay } - }, + }] : []), {{/lint}} { test: /\.vue$/, From dfbc19548b898c2430d69db49332a9552ba35230 Mon Sep 17 00:00:00 2001 From: Thorsten Date: Fri, 13 Oct 2017 10:14:23 +0200 Subject: [PATCH 03/12] fix node-notifier version --- template/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template/package.json b/template/package.json index 6b8b82765c..75fecc2301 100644 --- a/template/package.json +++ b/template/package.json @@ -67,7 +67,7 @@ "karma-spec-reporter": "0.0.31", "karma-webpack": "^2.0.2", "mocha": "^3.2.0", - "node-notifier": "5.1.2", + "node-notifier": "^5.1.2", "chai": "^4.1.2", "sinon": "^4.0.0", "sinon-chai": "^2.8.0", From 6800a9db4f4ba7bfeab85758d19699d481f7ed9c Mon Sep 17 00:00:00 2001 From: Thorsten Date: Fri, 13 Oct 2017 12:02:34 +0200 Subject: [PATCH 04/12] remove console.log --- template/build/utils.js | 1 - 1 file changed, 1 deletion(-) diff --git a/template/build/utils.js b/template/build/utils.js index f17f4a3e2b..b75c21502f 100644 --- a/template/build/utils.js +++ b/template/build/utils.js @@ -79,7 +79,6 @@ exports.createNotifierCallback = function () { if (severity !== 'error') { return } - console.log('it should notify!!') const error = errors[0] const filename = error.file.split('!').pop() From fb899117ae006229783046e4059fff25d8b3ea33 Mon Sep 17 00:00:00 2001 From: Thorsten Date: Fri, 13 Oct 2017 12:03:25 +0200 Subject: [PATCH 05/12] moved general dependency out of unit test-only dependency block. --- template/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template/package.json b/template/package.json index 75fecc2301..d7ae9e5d9f 100644 --- a/template/package.json +++ b/template/package.json @@ -67,7 +67,6 @@ "karma-spec-reporter": "0.0.31", "karma-webpack": "^2.0.2", "mocha": "^3.2.0", - "node-notifier": "^5.1.2", "chai": "^4.1.2", "sinon": "^4.0.0", "sinon-chai": "^2.8.0", @@ -75,6 +74,7 @@ "babel-plugin-istanbul": "^4.1.1", "phantomjs-prebuilt": "^2.1.14", {{/unit}} + "node-notifier": "^5.1.2", {{#e2e}} "chromedriver": "^2.27.2", "cross-spawn": "^5.0.1", From e0e884f99a829e020b27a8552d830f2a060d4fc4 Mon Sep 17 00:00:00 2001 From: Thorsten Date: Wed, 1 Nov 2017 16:16:59 +0100 Subject: [PATCH 06/12] fix typo --- template/build/webpack.dev.conf.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template/build/webpack.dev.conf.js b/template/build/webpack.dev.conf.js index 3c494b01ec..8498d3ad50 100644 --- a/template/build/webpack.dev.conf.js +++ b/template/build/webpack.dev.conf.js @@ -62,7 +62,7 @@ module.exports = new Promise((resolve, reject) => { // Add FriendlyErrorsPlugin devWebpackConfig.plugins.push(new FriendlyErrorsPlugin({ compilationSuccessInfo: { - messages: [`You application is running here http://${config.dev.host}:${port}`], + messages: [`Your application is running here: http://${config.dev.host}:${port}`], }, onErrors: config.dev.notifyOnErrors ? utils.createNotifierCallback() From 9891c863060a78ad66a5aa0de5de6a37eb5df9d3 Mon Sep 17 00:00:00 2001 From: Thorsten Date: Wed, 1 Nov 2017 16:17:08 +0100 Subject: [PATCH 07/12] ignore /test folder --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 80c45fbf35..5fb21d751f 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ node_modules .DS_Store docs/_book +test/ \ No newline at end of file From afe56e63bf0b09d25fa7e3efa4fd39179858b832 Mon Sep 17 00:00:00 2001 From: Thorsten Date: Wed, 1 Nov 2017 16:29:05 +0100 Subject: [PATCH 08/12] make HMR work correctly. --- template/build/webpack.dev.conf.js | 1 + template/package.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/template/build/webpack.dev.conf.js b/template/build/webpack.dev.conf.js index 8498d3ad50..fe9b220c34 100644 --- a/template/build/webpack.dev.conf.js +++ b/template/build/webpack.dev.conf.js @@ -17,6 +17,7 @@ const devWebpackConfig = merge(baseWebpackConfig, { // these devServer options should be customized in /config/index.js devServer: { + hot: true, host: process.env.HOST || config.dev.host, port: process.env.PORT || config.dev.port, open: config.dev.autoOpenBrowser, diff --git a/template/package.json b/template/package.json index d7ae9e5d9f..e4a6169756 100644 --- a/template/package.json +++ b/template/package.json @@ -5,7 +5,7 @@ "author": "{{ author }}", "private": true, "scripts": { - "dev": "webpack-dev-server --inline --hot --progress --config build/webpack.dev.conf.js", + "dev": "webpack-dev-server --inline --progress --config build/webpack.dev.conf.js", "start": "npm run dev", "build": "node build/build.js"{{#unit}}, "unit": "cross-env BABEL_ENV=test karma start test/unit/karma.conf.js --single-run"{{/unit}}{{#e2e}}, From 302e8410bb59ca96157944650f67a89d2f84801e Mon Sep 17 00:00:00 2001 From: Thorsten Date: Wed, 1 Nov 2017 16:29:38 +0100 Subject: [PATCH 09/12] improve console messages for HMR - now show filenames of replaced modules. --- template/build/webpack.dev.conf.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/template/build/webpack.dev.conf.js b/template/build/webpack.dev.conf.js index fe9b220c34..5afdbb170f 100644 --- a/template/build/webpack.dev.conf.js +++ b/template/build/webpack.dev.conf.js @@ -35,9 +35,9 @@ const devWebpackConfig = merge(baseWebpackConfig, { plugins: [ new webpack.DefinePlugin({ 'process.env': config.dev.env - }), - // https://github.com/glenjamin/webpack-hot-middleware#installation--usage + }), new webpack.HotModuleReplacementPlugin(), + new webpack.NamedModulesPlugin(), // HMR shows correct file names in console on update. new webpack.NoEmitOnErrorsPlugin(), // https://github.com/ampedandwired/html-webpack-plugin new HtmlWebpackPlugin({ From 11122cbb6af873adf5cb77ff201f94bf58cbba57 Mon Sep 17 00:00:00 2001 From: Thorsten Date: Wed, 1 Nov 2017 17:00:24 +0100 Subject: [PATCH 10/12] fix typo in eslint-loader config --- template/build/webpack.base.conf.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template/build/webpack.base.conf.js b/template/build/webpack.base.conf.js index e6985eef6d..89931abb7c 100644 --- a/template/build/webpack.base.conf.js +++ b/template/build/webpack.base.conf.js @@ -38,7 +38,7 @@ module.exports = { include: [resolve('src'), resolve('test')], options: { formatter: require('eslint-friendly-formatter'), - emitWaring: !config.dev.showEslintErrorsInOverlay + emitWarning: !config.dev.showEslintErrorsInOverlay } }] : []), {{/lint}} From 505446da38e19c5c45c194bf9d286d195130dc65 Mon Sep 17 00:00:00 2001 From: Thorsten Date: Wed, 1 Nov 2017 17:02:27 +0100 Subject: [PATCH 11/12] move imports for the env files from /config/index.js directly into the webpack config. Reasoning: thosen file imports are not configuration, so they don't belong inside of config/index.js --- template/build/webpack.dev.conf.js | 2 +- template/build/webpack.prod.conf.js | 2 +- template/config/index.js | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/template/build/webpack.dev.conf.js b/template/build/webpack.dev.conf.js index 5afdbb170f..33de427c3b 100644 --- a/template/build/webpack.dev.conf.js +++ b/template/build/webpack.dev.conf.js @@ -34,7 +34,7 @@ const devWebpackConfig = merge(baseWebpackConfig, { }, plugins: [ new webpack.DefinePlugin({ - 'process.env': config.dev.env + 'process.env': require('../config/dev.env') }), new webpack.HotModuleReplacementPlugin(), new webpack.NamedModulesPlugin(), // HMR shows correct file names in console on update. diff --git a/template/build/webpack.prod.conf.js b/template/build/webpack.prod.conf.js index 1b91741c2d..0fd64ae3f9 100644 --- a/template/build/webpack.prod.conf.js +++ b/template/build/webpack.prod.conf.js @@ -12,7 +12,7 @@ const OptimizeCSSPlugin = require('optimize-css-assets-webpack-plugin') const env = {{#if_or unit e2e}}process.env.NODE_ENV === 'testing' ? require('../config/test.env') - : {{/if_or}}config.build.env + : {{/if_or}}require('../config/prod.env') const webpackConfig = merge(baseWebpackConfig, { module: { diff --git a/template/config/index.js b/template/config/index.js index 1250e7e97b..bf4b30f69e 100644 --- a/template/config/index.js +++ b/template/config/index.js @@ -6,7 +6,6 @@ const path = require('path') module.exports = { dev: { - env: require('./dev.env'), host: 'localhost', // can be overwritten by process.env.HOST port: 8080, // can be overwritten by process.env.HOST, if port is in use, a free one will be determined @@ -37,7 +36,7 @@ module.exports = { cssSourceMap: false }, build: { - env: require('./prod.env'), + // Template for index.html index: path.resolve(__dirname, '../dist/index.html'), // Paths From 430406ebf7a6ac30f2fc9d3ba4ea8898c6a00914 Mon Sep 17 00:00:00 2001 From: Thorsten Date: Wed, 1 Nov 2017 20:57:36 +0100 Subject: [PATCH 12/12] fix wrong overlay config --- template/build/webpack.dev.conf.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template/build/webpack.dev.conf.js b/template/build/webpack.dev.conf.js index 33de427c3b..9b2429a5e1 100644 --- a/template/build/webpack.dev.conf.js +++ b/template/build/webpack.dev.conf.js @@ -22,7 +22,7 @@ const devWebpackConfig = merge(baseWebpackConfig, { port: process.env.PORT || config.dev.port, open: config.dev.autoOpenBrowser, overlay: config.dev.errorOverlay ? { - warnings: true, + warnings: false, errors: true, } : false, publicPath: config.dev.assetsPublicPath,