From 07b3c4b7860009e19446f3d78571556c5737d82a Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Mon, 27 May 2024 17:04:48 +0800 Subject: [PATCH] fix(compat): correctly transform non-identifier expressions in legacy filter syntax (#10896) close #10852 --- .../src/compat/transformFilter.ts | 2 ++ .../__tests__/compileTemplate.spec.ts | 31 +++++++++++++++++++ 2 files changed, 33 insertions(+) diff --git a/packages/compiler-core/src/compat/transformFilter.ts b/packages/compiler-core/src/compat/transformFilter.ts index 86d11f52a60..52b381567d5 100644 --- a/packages/compiler-core/src/compat/transformFilter.ts +++ b/packages/compiler-core/src/compat/transformFilter.ts @@ -168,6 +168,8 @@ function parseFilter(node: SimpleExpressionNode, context: TransformContext) { expression = wrapFilter(expression, filters[i], context) } node.content = expression + // reset ast since the content is replaced + node.ast = undefined } } diff --git a/packages/compiler-sfc/__tests__/compileTemplate.spec.ts b/packages/compiler-sfc/__tests__/compileTemplate.spec.ts index 45dc54a69db..2ea1eb9d378 100644 --- a/packages/compiler-sfc/__tests__/compileTemplate.spec.ts +++ b/packages/compiler-sfc/__tests__/compileTemplate.spec.ts @@ -1,4 +1,5 @@ import { type RawSourceMap, SourceMapConsumer } from 'source-map-js' +import { parse as babelParse } from '@babel/parser' import { type SFCTemplateCompileOptions, compileTemplate, @@ -452,6 +453,36 @@ test('prefixing edge case for reused AST ssr mode', () => { ).not.toThrowError() }) +// #10852 +test('non-identifier expression in legacy filter syntax', () => { + const src = ` + + ` + + const { descriptor } = parse(src) + const compilationResult = compileTemplate({ + id: 'xxx', + filename: 'test.vue', + ast: descriptor.template!.ast, + source: descriptor.template!.content, + ssr: false, + compilerOptions: { + compatConfig: { + MODE: 2, + }, + }, + }) + + expect(() => { + babelParse(compilationResult.code, { sourceType: 'module' }) + }).not.toThrow() +}) + interface Pos { line: number column: number