From 70f2f283eee1f34330d38687e5e6d69e2f1d371b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E8=BF=9C=E6=96=B9os?= <yangpanteng@gmail.com>
Date: Thu, 30 May 2024 18:27:38 +0800
Subject: [PATCH] refactor(types/compat): improve the types for $set and
 $delete (#8719)

---
 packages/runtime-core/src/compat/instance.ts | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/packages/runtime-core/src/compat/instance.ts b/packages/runtime-core/src/compat/instance.ts
index 18e745ca4e8..7b89c5ad61c 100644
--- a/packages/runtime-core/src/compat/instance.ts
+++ b/packages/runtime-core/src/compat/instance.ts
@@ -43,8 +43,15 @@ export type LegacyPublicInstance = ComponentPublicInstance &
   LegacyPublicProperties
 
 export interface LegacyPublicProperties {
-  $set(target: object, key: string, value: any): void
-  $delete(target: object, key: string): void
+  $set<T extends Record<keyof any, any>, K extends keyof T>(
+    target: T,
+    key: K,
+    value: T[K]
+  ): void
+  $delete<T extends Record<keyof any, any>, K extends keyof T>(
+    target: T,
+    key: K
+  ): void
   $mount(el?: string | Element): this
   $destroy(): void
   $scopedSlots: Slots