From 8ca9f68ca0e9fecfddf4317c6919ea0428da10ac Mon Sep 17 00:00:00 2001 From: chen fan <1490040662@qq.com> Date: Tue, 5 Sep 2023 09:10:10 +0800 Subject: [PATCH] perf: add __NO_SIDE_EFFECTS__ comment --- packages/reactivity/src/collectionHandlers.ts | 1 + packages/runtime-core/src/devtools.ts | 1 + packages/server-renderer/src/helpers/ssrRenderAttrs.ts | 2 +- packages/shared/src/general.ts | 1 + packages/shared/src/makeMap.ts | 2 ++ 5 files changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/reactivity/src/collectionHandlers.ts b/packages/reactivity/src/collectionHandlers.ts index 1d07af3be8c..a96cf0db8a9 100644 --- a/packages/reactivity/src/collectionHandlers.ts +++ b/packages/reactivity/src/collectionHandlers.ts @@ -331,6 +331,7 @@ const [ shallowReadonlyInstrumentations ] = /* #__PURE__*/ createInstrumentations() +/*! #__NO_SIDE_EFFECTS__ */ function createInstrumentationGetter(isReadonly: boolean, shallow: boolean) { const instrumentations = shallow ? isReadonly diff --git a/packages/runtime-core/src/devtools.ts b/packages/runtime-core/src/devtools.ts index bf67093f5c3..ba8c40fe012 100644 --- a/packages/runtime-core/src/devtools.ts +++ b/packages/runtime-core/src/devtools.ts @@ -123,6 +123,7 @@ export const devtoolsComponentRemoved = ( } } +/*! #__NO_SIDE_EFFECTS__ */ function createDevtoolsComponentHook(hook: DevtoolsHooks) { return (component: ComponentInternalInstance) => { emit( diff --git a/packages/server-renderer/src/helpers/ssrRenderAttrs.ts b/packages/server-renderer/src/helpers/ssrRenderAttrs.ts index 6bbf83a1eaa..c93efa13608 100644 --- a/packages/server-renderer/src/helpers/ssrRenderAttrs.ts +++ b/packages/server-renderer/src/helpers/ssrRenderAttrs.ts @@ -12,7 +12,7 @@ import { } from '@vue/shared' // leading comma for empty string "" -const shouldIgnoreProp = makeMap( +const shouldIgnoreProp = /*#__PURE__*/ makeMap( `,key,ref,innerHTML,textContent,ref_key,ref_for` ) diff --git a/packages/shared/src/general.ts b/packages/shared/src/general.ts index 0117e67000d..0163473312e 100644 --- a/packages/shared/src/general.ts +++ b/packages/shared/src/general.ts @@ -17,6 +17,7 @@ export const isOn = (key: string) => onRE.test(key) export const isModelListener = (key: string) => key.startsWith('onUpdate:') +/*! #__NO_SIDE_EFFECTS__ */ export const extend = Object.assign export const remove = (arr: T[], el: T) => { diff --git a/packages/shared/src/makeMap.ts b/packages/shared/src/makeMap.ts index b598704c673..e49b1bf3d36 100644 --- a/packages/shared/src/makeMap.ts +++ b/packages/shared/src/makeMap.ts @@ -5,6 +5,8 @@ * \/\*#\_\_PURE\_\_\*\/ * So that rollup can tree-shake them if necessary. */ + +/*! #__NO_SIDE_EFFECTS__ */ export function makeMap( str: string, expectsLowerCase?: boolean