Skip to content

Commit

Permalink
fix(runtime-core): set fragment root children should also update dyna…
Browse files Browse the repository at this point in the history
…micChildren (#944)

fix #943
  • Loading branch information
underfin authored Apr 8, 2020
1 parent bc78de2 commit a27e9ee
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion packages/runtime-core/src/componentRenderUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ const getChildRoot = (
return [vnode, undefined]
}
const rawChildren = vnode.children as VNodeArrayChildren
const dynamicChildren = vnode.dynamicChildren as VNodeArrayChildren
const children = rawChildren.filter(child => {
return !(isVNode(child) && child.type === Comment)
})
Expand All @@ -171,7 +172,13 @@ const getChildRoot = (
}
const childRoot = children[0]
const index = rawChildren.indexOf(childRoot)
const setRoot = (updatedRoot: VNode) => (rawChildren[index] = updatedRoot)
const dynamicIndex = dynamicChildren
? dynamicChildren.indexOf(childRoot)
: null
const setRoot = (updatedRoot: VNode) => {
rawChildren[index] = updatedRoot
if (dynamicIndex !== null) dynamicChildren[dynamicIndex] = updatedRoot
}
return [normalizeVNode(childRoot), setRoot]
}

Expand Down

0 comments on commit a27e9ee

Please sign in to comment.