diff --git a/packages/dts-test/reactivity.test-d.ts b/packages/dts-test/reactivity.test-d.ts index 4504f9e352d..431bbafbdf4 100644 --- a/packages/dts-test/reactivity.test-d.ts +++ b/packages/dts-test/reactivity.test-d.ts @@ -62,3 +62,31 @@ describe('should unwrap tuple correctly', () => { const reactiveTuple = reactive(tuple) expectType>(reactiveTuple[0]) }) + +describe('should unwrap Map correctly', () => { + const map = reactive(new Map>()) + expectType>(map.get('a')!) + + const map2 = reactive(new Map }>()) + expectType(map2.get('a')!.wrap) + + const wm = reactive(new WeakMap>()) + expectType>(wm.get({})!) + + const wm2 = reactive(new WeakMap }>()) + expectType(wm2.get({})!.wrap) +}) + +describe('should unwrap Set correctly', () => { + const set = reactive(new Set>()) + expectType>>(set) + + const set2 = reactive(new Set<{ wrap: Ref }>()) + expectType>(set2) + + const ws = reactive(new WeakSet>()) + expectType>>(ws) + + const ws2 = reactive(new WeakSet<{ wrap: Ref }>()) + expectType>(ws2) +}) diff --git a/packages/reactivity/src/collectionHandlers.ts b/packages/reactivity/src/collectionHandlers.ts index ecdcae00b7c..abf623f551c 100644 --- a/packages/reactivity/src/collectionHandlers.ts +++ b/packages/reactivity/src/collectionHandlers.ts @@ -3,7 +3,7 @@ import { track, trigger, ITERATE_KEY, MAP_KEY_ITERATE_KEY } from './effect' import { TrackOpTypes, TriggerOpTypes } from './operations' import { capitalize, hasOwn, hasChanged, toRawType, isMap } from '@vue/shared' -export type CollectionTypes = IterableCollections | WeakCollections +type CollectionTypes = IterableCollections | WeakCollections type IterableCollections = Map | Set type WeakCollections = WeakMap | WeakSet diff --git a/packages/reactivity/src/ref.ts b/packages/reactivity/src/ref.ts index 201766158ed..9f7ebdad822 100644 --- a/packages/reactivity/src/ref.ts +++ b/packages/reactivity/src/ref.ts @@ -17,7 +17,6 @@ import { isShallow } from './reactive' import type { ShallowReactiveMarker } from './reactive' -import { CollectionTypes } from './collectionHandlers' import { createDep, Dep } from './dep' declare const RefSymbol: unique symbol @@ -492,16 +491,23 @@ export type UnwrapRef = T extends ShallowRef export type UnwrapRefSimple = T extends | Function - | CollectionTypes | BaseTypes | Ref | RefUnwrapBailTypes[keyof RefUnwrapBailTypes] | { [RawSymbol]?: true } ? T - : T extends ReadonlyArray - ? { [K in keyof T]: UnwrapRefSimple } - : T extends object & { [ShallowReactiveMarker]?: never } - ? { - [P in keyof T]: P extends symbol ? T[P] : UnwrapRef - } - : T + : T extends Map + ? Map> + : T extends WeakMap + ? WeakMap> + : T extends Set + ? Set> + : T extends WeakSet + ? WeakSet> + : T extends ReadonlyArray + ? { [K in keyof T]: UnwrapRefSimple } + : T extends object & { [ShallowReactiveMarker]?: never } + ? { + [P in keyof T]: P extends symbol ? T[P] : UnwrapRef + } + : T