-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2278 causes kebab case listener not get triggered #2429
Comments
Your reproduction works... |
@posva have you clicked the "Hello Vue 3 in CodeSandbox!" ? If it works, the alert should appears. |
@posva I don't get any alert from clicking on HelloWorld's body, can't say this works. |
I'm having the same problem. |
Since #2278 now all events are camelCased, we now have to camelCase events everywhere, mainly in two places:
/cc @yyx990803 this is a pretty broad regression from |
If we make the changes i mentioned, docs could stay as they are. Pascal-Case recommended, but camel case works as well. |
This works correctly in a reproduction using 3.0.1 global build (https://jsfiddle.net/yyx990803/3scy68d5/1/) and also works on a fresh vue-cli project using 3.0.1. There could be a compiler/runtime version mismatch in your project that doesn't properly camelize the event when emitting (make sure your Closing since it's not reproducible. |
@LinusBorg @07akioni @posva can you guys confirm it's working on the iife version of vue >=3.0.1 ? |
yes, it's working |
Thanks, this was really helpful. Just updated a project I'm working on to 3.0.2 and ended up here because of events not firing/not being caught - |
Thanks guys, I don't know why, but it works now automatically... |
I'm still getting this issue w/ |
Please open a new issue. This will get drowned out. |
Version
3.0.1
Reproduction link
https://codesandbox.io/s/dreamy-khayyam-m06w1?file=/src/App.vue
Steps to reproduce
What is expected?
The doc recommends using kebab case for event names, but #2278 breaks this.
https://v3.vuejs.org/guide/component-custom-events.html#event-names
What is actually happening?
After #2278 got merged, my code shown above won't work.
(You might want to write some tests before merge. Thanks!)
The text was updated successfully, but these errors were encountered: